Rename methods in PluginConfigFactory to be more explicit

The methods in PluginConfigFactory that return the plugin
configuration are renamed so that it is more explicit which plugin
configuration is returned (the plugin configuration from
'gerrit.config' or from 'project.config').

This renaming breaks plugins that already use PluginConfigFactory, but
since PluginConfigFactory was introduced quite late in the 2.8
development phase it should be OK to do the rename before 2.8 is
released.

In a future change it is planned to add support for plugin
configuration that is stored in own configuration files (e.g.
'my-plugin.config'). For this it is required to add new accessor
methods to PluginConfigFactory. The rename of the existing methods
ensures that there will be no conflict with the names of the new
accessor methods.

In addition this change adds JavaDoc comments to the methods in
PluginConfigFactory so that it is more clear which plugin
configuration they return.

Change-Id: I7c3e97d70cb16457cab6062e5d5126d8ed5de022
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
2 files changed