commit 0b09419e6050dd4b3bd0a6b01179f1654d4229df
author Ben Rohlfs <brohlfs@google.com> Tue Jan 21 09:03:49 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Jan 21 09:03:49 2020 +0000
tree 6e8aceee1a5087ac548b6d63ae89d96ff37273bf
parent 17f3325b5e44220b5707874dac3ca537402e85d9
parent efe3c04eace0894ae5eb3512d6468fed91a14e8d

Merge "Add a warning when the overlay open promise does not resolve"

polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js

diff --git a/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js b/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js
index 8821bcb..5dee2fe 100644
--- a/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js
+++ b/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js
@@ -104,6 +104,12 @@
             fn.call(this);
           } else if (iters++ < AWAIT_MAX_ITERS) {
             step.call(this);
+          } else {
+            // TODO(crbug.com/gerrit/10774): Once this is confirmed as the root
+            // cause of the bug, fix it by either making sure to resolve the fn
+            // function or find a better way to listen on the overlay being
+            // shown.
+            console.warn('gr-overlay _awaitOpen failed to resolve');
           }
         }, AWAIT_STEP);
       };