commit 092c61be3da89c8a425e44e477604a96166b06ea
author Changcheng Xiao <xchangcheng@google.com> Wed Jul 18 09:48:30 2018 +0200
committer Changcheng Xiao <xchangcheng@google.com> Wed Jul 18 09:52:04 2018 +0200
tree 0a21199aee90831dca8706414ecbe710f2a9ef3d
parent 181b0bbd367e5784cb507e07fe7111a4d84c3937

ListDashboards: move project state check forward

Change-Id: I3be47adb48884023c0992c2a9a54edddf876caa7

java/com/google/gerrit/server/restapi/project/ListDashboards.java

diff --git a/java/com/google/gerrit/server/restapi/project/ListDashboards.java b/java/com/google/gerrit/server/restapi/project/ListDashboards.java
index 06dbdb0..3808a2f 100644
--- a/java/com/google/gerrit/server/restapi/project/ListDashboards.java
+++ b/java/com/google/gerrit/server/restapi/project/ListDashboards.java
@@ -16,6 +16,7 @@
 
 import static com.google.gerrit.reviewdb.client.RefNames.REFS_DASHBOARDS;
 
+import com.google.common.collect.ImmutableList;
 import com.google.common.flogger.FluentLogger;
 import com.google.gerrit.extensions.api.projects.DashboardInfo;
 import com.google.gerrit.extensions.restapi.AuthException;
@@ -100,15 +101,15 @@
 
   private List<DashboardInfo> scan(ProjectState state, String project, boolean setDefault)
       throws ResourceNotFoundException, IOException, PermissionBackendException {
+    if (!state.statePermitsRead()) {
+      return ImmutableList.of();
+    }
+
     PermissionBackend.ForProject perm = permissionBackend.currentUser().project(state.getNameKey());
     try (Repository git = gitManager.openRepository(state.getNameKey());
         RevWalk rw = new RevWalk(git)) {
       List<DashboardInfo> all = new ArrayList<>();
       for (Ref ref : git.getRefDatabase().getRefsByPrefix(REFS_DASHBOARDS)) {
-        if (!state.statePermitsRead()) {
-          continue;
-        }
-
         try {
           perm.ref(ref.getName()).check(RefPermission.READ);
           all.addAll(scanDashboards(state.getProject(), git, rw, ref, project, setDefault));