Remove Event type from globals.ts
Event interface is already defined in lib.dom.d.ts which has
composedPath() property supported by all browsers instead of the
Event interface defined in globals.ts which uses non-supported
property path.
Change-Id: I44cd2a6bce83548151ef2fdbcbf3bf6c6efa3c6b
diff --git a/polygerrit-ui/app/elements/gr-app-element.ts b/polygerrit-ui/app/elements/gr-app-element.ts
index 617034b..bd38808 100644
--- a/polygerrit-ui/app/elements/gr-app-element.ts
+++ b/polygerrit-ui/app/elements/gr-app-element.ts
@@ -507,11 +507,10 @@
if (e.ctrlKey) key = 'ctrl+' + key;
if (e.metaKey) key = 'meta+' + key;
if (e.altKey) key = 'alt+' + key;
+ const path = event.composedPath();
this.reporting.reportInteraction('shortcut-triggered', {
key,
- from:
- (event.path && event.path[0] && (event.path[0] as Element).nodeName) ??
- 'unknown',
+ from: (path && path[0] && (path[0] as Element).nodeName) ?? 'unknown',
});
}
diff --git a/polygerrit-ui/app/types/globals.ts b/polygerrit-ui/app/types/globals.ts
index 28cac87..d208d4f 100644
--- a/polygerrit-ui/app/types/globals.ts
+++ b/polygerrit-ui/app/types/globals.ts
@@ -126,13 +126,6 @@
};
}
- interface Event {
- // path is a non-standard property. Actually, this is optional property,
- // but marking it as optional breaks CustomKeyboardEvent
- // TODO(TS): replace with composedPath if possible
- readonly path: EventTarget[];
- }
-
interface Error {
lineNumber?: number; // non-standard property
columnNumber?: number; // non-standard property
