Merge changes I1109347f,I16f79dd6 * changes: Fix a weird layering issue with check action tooltips Remove '- filtered' text from check result section title
diff --git a/polygerrit-ui/app/elements/checks/gr-checks-action.ts b/polygerrit-ui/app/elements/checks/gr-checks-action.ts index 82680aa..9fe86c8 100644 --- a/polygerrit-ui/app/elements/checks/gr-checks-action.ts +++ b/polygerrit-ui/app/elements/checks/gr-checks-action.ts
@@ -41,6 +41,13 @@ display: inline-block; } gr-button { + /* It is not fully understood why this is needed, but otherwise the + paper-tooltip may render under some iron-icons of the content + below. Maybe this has to do with a z-index:0 setting for + paper-button, such that a stacking context is created. And the high + z-index of the paper-tooltip will then only be interpreted within + that stacking context. */ + z-index: 1; --padding: var(--spacing-s) var(--spacing-m); } gr-button paper-tooltip {
diff --git a/polygerrit-ui/app/elements/checks/gr-checks-results.ts b/polygerrit-ui/app/elements/checks/gr-checks-results.ts index 49bfbc2..b11b6d0 100644 --- a/polygerrit-ui/app/elements/checks/gr-checks-results.ts +++ b/polygerrit-ui/app/elements/checks/gr-checks-results.ts
@@ -1190,9 +1190,7 @@ class="statusIcon ${catString}" ></iron-icon> <span class="title">${catString}</span> - <span class="count" - >${this.renderCount(all, selected, filtered)}</span - > + <span class="count">${this.renderCount(all, filtered)}</span> <paper-tooltip offset="5" >${CATEGORY_TOOLTIPS.get(category)}</paper-tooltip > @@ -1282,13 +1280,10 @@ `; } - renderCount(all: RunResult[], selected: RunResult[], filtered: RunResult[]) { + renderCount(all: RunResult[], filtered: RunResult[]) { if (all.length === filtered.length) { return html`(${all.length})`; } - if (all.length !== selected.length) { - return html`<span class="filtered"> - filtered</span>`; - } return html`(${filtered.length} of ${all.length})`; }