| // Copyright (C) 2016 The Android Open Source Project |
| // |
| // Licensed under the Apache License, Version 2.0 (the "License"); |
| // you may not use this file except in compliance with the License. |
| // You may obtain a copy of the License at |
| // |
| // http://www.apache.org/licenses/LICENSE-2.0 |
| // |
| // Unless required by applicable law or agreed to in writing, software |
| // distributed under the License is distributed on an "AS IS" BASIS, |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| // See the License for the specific language governing permissions and |
| // limitations under the License. |
| |
| package com.google.gerrit.acceptance.api.accounts; |
| |
| import static com.google.common.truth.Truth.assertThat; |
| import static com.google.common.truth.TruthJUnit.assume; |
| import static java.util.concurrent.TimeUnit.SECONDS; |
| import static org.junit.Assert.fail; |
| |
| import com.google.common.collect.ImmutableList; |
| import com.google.gerrit.acceptance.AbstractDaemonTest; |
| import com.google.gerrit.common.data.ContributorAgreement; |
| import com.google.gerrit.common.data.GroupReference; |
| import com.google.gerrit.common.data.PermissionRule; |
| import com.google.gerrit.extensions.api.changes.CherryPickInput; |
| import com.google.gerrit.extensions.api.changes.ReviewInput; |
| import com.google.gerrit.extensions.api.changes.SubmitInput; |
| import com.google.gerrit.extensions.api.groups.GroupApi; |
| import com.google.gerrit.extensions.api.projects.BranchInfo; |
| import com.google.gerrit.extensions.api.projects.BranchInput; |
| import com.google.gerrit.extensions.client.InheritableBoolean; |
| import com.google.gerrit.extensions.common.AgreementInfo; |
| import com.google.gerrit.extensions.common.ChangeInfo; |
| import com.google.gerrit.extensions.common.ChangeInput; |
| import com.google.gerrit.extensions.restapi.AuthException; |
| import com.google.gerrit.extensions.restapi.BadRequestException; |
| import com.google.gerrit.extensions.restapi.MethodNotAllowedException; |
| import com.google.gerrit.extensions.restapi.UnprocessableEntityException; |
| import com.google.gerrit.reviewdb.client.AccountGroup; |
| import com.google.gerrit.server.git.ProjectConfig; |
| import com.google.gerrit.testutil.ConfigSuite; |
| import com.google.gerrit.testutil.TestTimeUtil; |
| |
| import org.eclipse.jgit.lib.Config; |
| import org.junit.AfterClass; |
| import org.junit.Before; |
| import org.junit.BeforeClass; |
| import org.junit.Test; |
| |
| import java.util.List; |
| |
| public class AgreementsIT extends AbstractDaemonTest { |
| private ContributorAgreement ca; |
| private ContributorAgreement ca2; |
| |
| @ConfigSuite.Config |
| public static Config enableAgreementsConfig() { |
| Config cfg = new Config(); |
| cfg.setBoolean("auth", null, "contributorAgreements", true); |
| return cfg; |
| } |
| |
| @BeforeClass |
| public static void setTimeForTesting() { |
| TestTimeUtil.resetWithClockStep(1, SECONDS); |
| } |
| |
| @AfterClass |
| public static void restoreTime() { |
| TestTimeUtil.useSystemTime(); |
| } |
| |
| @Before |
| public void setUp() throws Exception { |
| String g = createGroup("cla-test-group"); |
| GroupApi groupApi = gApi.groups().id(g); |
| groupApi.description("CLA test group"); |
| AccountGroup caGroup = groupCache.get( |
| new AccountGroup.UUID(groupApi.detail().id)); |
| GroupReference groupRef = GroupReference.forGroup(caGroup); |
| PermissionRule rule = new PermissionRule(groupRef); |
| rule.setAction(PermissionRule.Action.ALLOW); |
| ca = new ContributorAgreement("cla-test"); |
| ca.setDescription("description"); |
| ca.setAgreementUrl("agreement-url"); |
| ca.setAutoVerify(groupRef); |
| ca.setAccepted(ImmutableList.of(rule)); |
| |
| ca2 = new ContributorAgreement("cla-test-no-auto-verify"); |
| ca2.setDescription("description"); |
| ca2.setAgreementUrl("agreement-url"); |
| |
| ProjectConfig cfg = projectCache.checkedGet(allProjects).getConfig(); |
| cfg.replace(ca); |
| cfg.replace(ca2); |
| saveProjectConfig(allProjects, cfg); |
| setApiUser(user); |
| } |
| |
| @Test |
| public void signNonExistingAgreement() throws Exception { |
| assume().that(isContributorAgreementsEnabled()).isTrue(); |
| exception.expect(UnprocessableEntityException.class); |
| exception.expectMessage("contributor agreement not found"); |
| gApi.accounts().self().signAgreement("does-not-exist"); |
| } |
| |
| @Test |
| public void signAgreementNoAutoVerify() throws Exception { |
| assume().that(isContributorAgreementsEnabled()).isTrue(); |
| exception.expect(BadRequestException.class); |
| exception.expectMessage("cannot enter a non-autoVerify agreement"); |
| gApi.accounts().self().signAgreement(ca2.getName()); |
| } |
| |
| @Test |
| public void signAgreement() throws Exception { |
| assume().that(isContributorAgreementsEnabled()).isTrue(); |
| |
| // List of agreements is initially empty |
| List<AgreementInfo> result = gApi.accounts().self().listAgreements(); |
| assertThat(result).isEmpty(); |
| |
| // Sign the agreement |
| gApi.accounts().self().signAgreement(ca.getName()); |
| |
| // Explicitly reset the user to force a new request context |
| setApiUser(user); |
| |
| // Verify that the agreement was signed |
| result = gApi.accounts().self().listAgreements(); |
| assertThat(result).hasSize(1); |
| AgreementInfo info = result.get(0); |
| assertThat(info.name).isEqualTo(ca.getName()); |
| assertThat(info.description).isEqualTo(ca.getDescription()); |
| assertThat(info.url).isEqualTo(ca.getAgreementUrl()); |
| |
| // Signing the same agreement again has no effect |
| gApi.accounts().self().signAgreement(ca.getName()); |
| result = gApi.accounts().self().listAgreements(); |
| assertThat(result).hasSize(1); |
| } |
| |
| @Test |
| public void agreementsDisabledSign() throws Exception { |
| assume().that(isContributorAgreementsEnabled()).isFalse(); |
| exception.expect(MethodNotAllowedException.class); |
| exception.expectMessage("contributor agreements disabled"); |
| gApi.accounts().self().signAgreement(ca.getName()); |
| } |
| |
| @Test |
| public void agreementsDisabledList() throws Exception { |
| assume().that(isContributorAgreementsEnabled()).isFalse(); |
| exception.expect(MethodNotAllowedException.class); |
| exception.expectMessage("contributor agreements disabled"); |
| gApi.accounts().self().listAgreements(); |
| } |
| |
| @Test |
| public void revertChangeWithoutCLA() throws Exception { |
| assume().that(isContributorAgreementsEnabled()).isTrue(); |
| |
| // Create a change succeeds when agreement is not required |
| setUseContributorAgreements(InheritableBoolean.FALSE); |
| ChangeInfo change = gApi.changes().create(newChangeInput()).get(); |
| |
| // Approve and submit it |
| setApiUser(admin); |
| gApi.changes().id(change.changeId).current().review(ReviewInput.approve()); |
| gApi.changes().id(change.changeId).current().submit(new SubmitInput()); |
| |
| // Revert is not allowed when CLA is required but not signed |
| setApiUser(user); |
| setUseContributorAgreements(InheritableBoolean.TRUE); |
| exception.expect(AuthException.class); |
| exception.expectMessage("A Contributor Agreement must be completed"); |
| gApi.changes().id(change.changeId).revert(); |
| } |
| |
| @Test |
| public void cherrypickChangeWithoutCLA() throws Exception { |
| assume().that(isContributorAgreementsEnabled()).isTrue(); |
| |
| // Create a new branch |
| setApiUser(admin); |
| BranchInfo dest = gApi.projects().name(project.get()) |
| .branch("cherry-pick-to").create(new BranchInput()).get(); |
| |
| // Create a change succeeds when agreement is not required |
| setUseContributorAgreements(InheritableBoolean.FALSE); |
| ChangeInfo change = gApi.changes().create(newChangeInput()).get(); |
| |
| // Approve and submit it |
| gApi.changes().id(change.changeId).current().review(ReviewInput.approve()); |
| gApi.changes().id(change.changeId).current().submit(new SubmitInput()); |
| |
| // Cherry-pick is not allowed when CLA is required but not signed |
| setApiUser(user); |
| setUseContributorAgreements(InheritableBoolean.TRUE); |
| CherryPickInput in = new CherryPickInput(); |
| in.destination = dest.ref; |
| in.message = change.subject; |
| exception.expect(AuthException.class); |
| exception.expectMessage("A Contributor Agreement must be completed"); |
| gApi.changes().id(change.changeId).current().cherryPick(in); |
| } |
| |
| @Test |
| public void createChangeRespectsCLA() throws Exception { |
| assume().that(isContributorAgreementsEnabled()).isTrue(); |
| |
| // Create a change succeeds when agreement is not required |
| setUseContributorAgreements(InheritableBoolean.FALSE); |
| gApi.changes().create(newChangeInput()); |
| |
| // Create a change is not allowed when CLA is required but not signed |
| setUseContributorAgreements(InheritableBoolean.TRUE); |
| try { |
| gApi.changes().create(newChangeInput()); |
| fail("Expected AuthException"); |
| } catch (AuthException e) { |
| assertThat(e.getMessage()).contains( |
| "A Contributor Agreement must be completed"); |
| } |
| |
| // Sign the agreement |
| gApi.accounts().self().signAgreement(ca.getName()); |
| |
| // Explicitly reset the user to force a new request context |
| setApiUser(user); |
| |
| // Create a change succeeds after signing the agreement |
| gApi.changes().create(newChangeInput()); |
| } |
| |
| private ChangeInput newChangeInput() { |
| ChangeInput in = new ChangeInput(); |
| in.branch = "master"; |
| in.subject = "test"; |
| in.project = project.get(); |
| return in; |
| } |
| } |