| commit | 9fb97511d6c8bfa9abdef38c25d369fa651b0eaf | [log] [tgz] |
|---|---|---|
| author | Han-Wen Nienhuys <hanwen@google.com> | Wed Nov 27 17:09:59 2019 +0000 |
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Wed Nov 27 17:09:59 2019 +0000 |
| tree | aa4b76e45b6983c10f44297091084f98e5c2692a | |
| parent | f5f9bb8e686b01a38d913f4ca6ea0692a056157a [diff] | |
| parent | b5f89e1c27545fed302dd301bcf8309d313c759b [diff] |
Merge "cmd/checker: use query by scheme"
This is a style verifier intended to be used with the Gerrit checks plugin.
go install github.com/bazelbuild/buildtools/buildifier curl -o google-java-format.jar https://github.com/google/google-java-format/releases/download/google-java-format-1.7/google-java-format-1.7-all-deps.jar
Obtain an HTTP password, and put it in testsite-auth. The format is username:secret.
Register a checker
go run ./cmd/checker -auth_file=testsite-auth --gerrit http://localhost:8080 \ --language go --repo gerrit --register
go run ./cmd/checker -auth_file=testsite-auth --gerrit http://localhost:8080 \ --list
go run ./cmd/checker -auth_file=testsite-auth --gerrit http://localhost:8080
For simplicity of deployment, gerritfmt checker is stateless. All the necessary data is encoded in the checker UUID
handle file types (symlink) and deletions
more formatters: clang-format, typescript, jsformat, ... ?
isolate each formatter to run with a separate gvisor/docker container.
tests: the only way to test this reliably is to spin up a gerrit server, and create changes against the server.
Update the list of checkers periodically.
This currently runs the formatters without sandboxing. Critical bugs (heap overflow, buffer overflow) in formatters can be escalated to obtain the OAuth2 token used for authentication.
The currently supported formatters are written in Java and Go, so this should not be an issue.
This is not an official Google product