Clone this repo:

Branches

  1. f5f9bb8 Merge "gerrit: don't fetch content for deleted files" by Han-Wen Nienhuys · 6 days ago master
  2. 045b67a gerrit: don't fetch content for deleted files by Han-Wen Nienhuys · 6 days ago
  3. dd908a9 Merge "server: add .jar extension" by Han-Wen Nienhuys · 6 days ago
  4. 1e17b11 server: add .jar extension by Han-Wen Nienhuys · 6 days ago
  5. ff99c3b Merge "build-deploy.sh: chmod, and follow redirect" by Han-Wen Nienhuys · 6 days ago

GERRITFMT

This is a style verifier intended to be used with the Gerrit checks plugin.

HOW TO USE

  1. Install formatters:
go install github.com/bazelbuild/buildtools/buildifier
curl -o google-java-format.jar https://github.com/google/google-java-format/releases/download/google-java-format-1.7/google-java-format-1.7-all-deps.jar
  1. Obtain an HTTP password, and put it in testsite-auth. The format is username:secret.

  2. Register a checker

go run ./cmd/checker -auth_file=testsite-auth  --gerrit http://localhost:8080 \
  --language go --repo gerrit --register
  1. Make sure the checker is there
go run ./cmd/checker -auth_file=testsite-auth  --gerrit http://localhost:8080 \
  --list
  1. Start the server
go run ./cmd/checker -auth_file=testsite-auth  --gerrit http://localhost:8080

DESIGN

For simplicity of deployment, gerritfmt checker is stateless. All the necessary data is encoded in the checker UUID

TODO

  • handle file types (symlink) and deletions

  • more formatters: clang-format, typescript, jsformat, ... ?

  • isolate each formatter to run with a separate gvisor/docker container.

  • tests: the only way to test this reliably is to spin up a gerrit server, and create changes against the server.

  • Update the list of checkers periodically.

SECURITY

This currently runs the formatters without sandboxing. Critical bugs (heap overflow, buffer overflow) in formatters can be escalated to obtain the OAuth2 token used for authentication.

The currently supported formatters are written in Java and Go, so this should not be an issue.

DISCLAIMER

This is not an official Google product