Use default notify for Verified+1
Ideally we would never notify anyone other than the owner if the change
is Work in Progress. Gerrit has been modified[1] to customize the notify
level of comments when not given explicitly. It customizes according to
the tag and whether the change is currently in the WIP state.
If we no longer set notify on positive votes, then Gerrit will preserve
existing behavior (OWNER_REVIEWERS), and also make sure WIP changes
remain silent (OWNER).
[1] I0a30a43065be1e00f53ac25d937141dc4ea1e8f2
Change-Id: I83ec178ba90d5b6bfa16e7ab74aea71e8046cbf3
diff --git a/jenkins/gerrit-verifier-change.groovy b/jenkins/gerrit-verifier-change.groovy
index 4d99e9f..68567f1 100644
--- a/jenkins/gerrit-verifier-change.groovy
+++ b/jenkins/gerrit-verifier-change.groovy
@@ -119,9 +119,10 @@
}
def gerritLabel(changeNum, sha1, label, score, msgBody = "") {
+ def notify = score < 0 ? ', "notify" : "OWNER"' : ''
def jsonPayload = '{"labels":{"' + label + '":' + score + '},' +
- ' "message": "' + msgBody + '", ' +
- ' "notify" : "' + (score < 0 ? "OWNER": "OWNER_REVIEWERS") + "\" , ${Globals.addVerifiedTag} }"
+ ' "message": "' + msgBody + '"' +
+ notify + ", ${Globals.addVerifiedTag} }"
return gerritPost("a/changes/" + changeNum + "/revisions/" + sha1 + "/review",
jsonPayload)
