Avoid boilerplate in no tests found use case
As suggested in this upstream issue: [1] use always pass test to avoid
Bazel returning exit code 4 and corresponding boilerplate in no tests
found use case.
[1] https://github.com/bazelbuild/bazel/issues/11465
Change-Id: I3b102d0efae69cf975e0e2787537efc5898d5938
diff --git a/jenkins/gerrit-bazel-build-account-plugin.sh b/jenkins/gerrit-bazel-build-account-plugin.sh
index 3cbf149..45d1ba2 100644
--- a/jenkins/gerrit-bazel-build-account-plugin.sh
+++ b/jenkins/gerrit-bazel-build-account-plugin.sh
@@ -28,20 +28,7 @@
java -fullversion
bazelisk version
bazelisk build --spawn_strategy=standalone --genrule_strategy=standalone $TARGETS
-
-echo 'Running tests...'
-set +e
-bazelisk test --test_env DOCKER_HOST=$DOCKER_HOST plugins/account/...
-TEST_RES=$?
-set -e
-if [ $TEST_RES -eq 4 ]
-then
- echo 'No tests found for account plugin (tell this to the plugin maintainers?).'
-elif [ ! $TEST_RES -eq 0 ]
-then
- echo 'Tests failed'
- exit 1
-fi
+bazelisk test --test_env DOCKER_HOST=$DOCKER_HOST //tools/bzl:always_pass_test plugins/account/...
for JAR in $(find bazel-bin/plugins/account -name account*.jar)
do
diff --git a/jenkins/gerrit-bazel-build-its-plugin-branch.sh b/jenkins/gerrit-bazel-build-its-plugin-branch.sh
index 0f8bae0..f81ff5d 100644
--- a/jenkins/gerrit-bazel-build-its-plugin-branch.sh
+++ b/jenkins/gerrit-bazel-build-its-plugin-branch.sh
@@ -26,20 +26,7 @@
java -fullversion
bazelisk version
bazelisk build --spawn_strategy=standalone --genrule_strategy=standalone $TARGETS
-
-echo 'Running tests...'
-set +e
-bazelisk test --test_env DOCKER_HOST=$DOCKER_HOST plugins/its-{name}/...
-TEST_RES=$?
-set -e
-if [ $TEST_RES -eq 4 ]
-then
- echo 'No tests found for its plugin (tell this to the plugin maintainers?).'
-elif [ ! $TEST_RES -eq 0 ]
-then
- echo 'Tests failed'
- exit 1
-fi
+bazelisk test --test_env DOCKER_HOST=$DOCKER_HOST //tools/bzl:always_pass_test plugins/its-{name}/...
for JAR in $(find bazel-bin/plugins/its-{name} -name its-{name}*.jar)
do
diff --git a/jenkins/gerrit-bazel-build-its-plugin.sh b/jenkins/gerrit-bazel-build-its-plugin.sh
index 39fc2a4..e545573 100644
--- a/jenkins/gerrit-bazel-build-its-plugin.sh
+++ b/jenkins/gerrit-bazel-build-its-plugin.sh
@@ -22,20 +22,7 @@
java -fullversion
bazelisk version
bazelisk build --spawn_strategy=standalone --genrule_strategy=standalone $TARGETS
-
-echo 'Running tests...'
-set +e
-bazelisk test --test_env DOCKER_HOST=$DOCKER_HOST plugins/its-{name}/...
-TEST_RES=$?
-set -e
-if [ $TEST_RES -eq 4 ]
-then
- echo 'No tests found for its plugin (tell this to the plugin maintainers?).'
-elif [ ! $TEST_RES -eq 0 ]
-then
- echo 'Tests failed'
- exit 1
-fi
+bazelisk test --test_env DOCKER_HOST=$DOCKER_HOST //tools/bzl:always_pass_test plugins/its-{name}/...
for JAR in $(find bazel-bin/plugins/its-{name} -name its-{name}*.jar)
do
diff --git a/jenkins/gerrit-bazel-build-plugin-branch.sh b/jenkins/gerrit-bazel-build-plugin-branch.sh
index 7892d5e..7a85001 100644
--- a/jenkins/gerrit-bazel-build-plugin-branch.sh
+++ b/jenkins/gerrit-bazel-build-plugin-branch.sh
@@ -28,20 +28,7 @@
--test_timeout 3600 \
--test_tag_filters=-flaky \
--test_env DOCKER_HOST=$DOCKER_HOST"
-
-echo 'Running tests...'
-set +e
-bazelisk test $BAZEL_OPTS plugins/{name}/...
-TEST_RES=$?
-set -e
-if [ $TEST_RES -eq 4 ]
-then
- echo 'No tests found for this plugin (tell this to the plugin maintainers?).'
-elif [ ! $TEST_RES -eq 0 ]
-then
- echo 'Tests failed'
- exit 1
-fi
+bazelisk test $BAZEL_OPTS //tools/bzl:always_pass_test plugins/{name}/...
for JAR in $(find bazel-bin/plugins/{name} -name {name}*.jar)
do
diff --git a/jenkins/gerrit-bazel-build-plugin.sh b/jenkins/gerrit-bazel-build-plugin.sh
index f470616..b05c2a4 100644
--- a/jenkins/gerrit-bazel-build-plugin.sh
+++ b/jenkins/gerrit-bazel-build-plugin.sh
@@ -17,20 +17,7 @@
java -fullversion
bazelisk version
bazelisk build --spawn_strategy=standalone --genrule_strategy=standalone $TARGETS
-
-echo 'Running tests...'
-set +e
-bazelisk test --test_env DOCKER_HOST=$DOCKER_HOST plugins/{name}/...
-TEST_RES=$?
-set -e
-if [ $TEST_RES -eq 4 ]
-then
- echo 'No tests found for this plugin (tell this to the plugin maintainers?).'
-elif [ ! $TEST_RES -eq 0 ]
-then
- echo 'Tests failed'
- exit 1
-fi
+bazelisk test --test_env DOCKER_HOST=$DOCKER_HOST //tools/bzl:always_pass_test plugins/{name}/...
for JAR in $(find bazel-bin/plugins/{name} -name {name}*.jar)
do
diff --git a/jenkins/gerrit-bazel-verifier-test.sh b/jenkins/gerrit-bazel-verifier-test.sh
index 50e672e..0bda35b 100755
--- a/jenkins/gerrit-bazel-verifier-test.sh
+++ b/jenkins/gerrit-bazel-verifier-test.sh
@@ -41,15 +41,7 @@
fi
echo 'Running Documentation tests...'
- set +e
- bazelisk test $BAZEL_OPTS Documentation/...
- TEST_RES=$?
- set -e
- if [ ! $TEST_RES -eq 4 ] && [ ! $TEST_RES -eq 0 ]
- then
- echo 'Documentation tests failed'
- exit 1
- fi
+ bazelisk test $BAZEL_OPTS //tools/bzl:always_pass_test Documentation/...
if [ -z "$SAUCE_USERNAME" ] || [ -z "$SAUCE_ACCESS_KEY" ]
then
