commit 626c198f7ed621cd510e285118f0ee1c923e52af
author David Ostrovsky <david@ostrovsky.org> Mon Nov 09 14:18:46 2015 -0800
committer David Ostrovsky <david@ostrovsky.org> Mon Nov 09 15:29:49 2015 -0800
tree c6a66fdf2c518e704df09cf135b952202a9c9213
parent 435da51708dc920a57bc8935c347694faa837c19

Buck: Upgrade to the latest version

Since [1] genrule() target doesn't accept deps parameters any more.
As replacement, cmd should use $(location :foo) macro. Reshuffle some
rules to fix existing genrule targets. Remove all rule, as it cannot
depend any more on api and release. Moreover create all.zip with both
api.zip and release.war included doesn't make really sense. Adjust the
documentation correspondingly.

gen_licences.py is accepting first order dependencies and computes the
classpath on its own. Make it work for now by passing the classpath for
the dependencies.  Add a TODO to clean this up and accept the classpath
from the Buck side, similar to what was done in Ifd2dcf69aa.

[1] https://github.com/facebook/buck/commit/d2c6edbf7b41ee5662902c1f06f570fa4bc8e005

Change-Id: Ia8ce9c1c9dc30bb88d186d5d6556aa9acbacfaed

buckversion

diff --git a/buckversion b/buckversion
index ab18d5d..9daac2c 100644
--- a/buckversion
+++ b/buckversion
@@ -1 +1 @@
-7e153d4a69044d059288d353fc1a442e07cbea58
+1b03b4313b91b634bd604fc3487a05f877e59dee

java_doc.bucklet

diff --git a/java_doc.bucklet b/java_doc.bucklet
index 69df603..187f4c0 100644
--- a/java_doc.bucklet
+++ b/java_doc.bucklet
@@ -55,7 +55,6 @@
       '-d $TMP',
     ]) + ';jar cf $OUT -C $TMP .',
     srcs = srcs,
-    deps = deps,
     out = name + '.jar',
     visibility = visibility,
 )

maven_jar.bucklet

diff --git a/maven_jar.bucklet b/maven_jar.bucklet
index 0692fc4..0a22d6d 100644
--- a/maven_jar.bucklet
+++ b/maven_jar.bucklet
@@ -120,7 +120,6 @@
   genrule(
     name = name + '__download_bin',
     cmd = ' '.join(cmd),
-    deps = ['//bucklets/tools:download_file'],
     out = binjar,
   )
 
@@ -136,7 +135,6 @@
     genrule(
       name = name + '__download_src',
       cmd = ' '.join(cmd),
-      deps = ['//bucklets/tools:download_file'],
       out = srcjar,
     )
     prebuilt_jar(

maven_package.bucklet

diff --git a/maven_package.bucklet b/maven_package.bucklet
index e8c855d..f758fcb 100644
--- a/maven_package.bucklet
+++ b/maven_package.bucklet
@@ -40,17 +40,14 @@
     '-v', version,
     '-o', '$OUT',
   ]
-  dep = []
 
   for type,d in [('jar', jar), ('java-source', src), ('javadoc', doc)]:
     for a,t in d.iteritems():
       cmd.append('-s %s:%s:$(location %s)' % (a,type,t))
-      dep.append(t)
 
   genrule(
     name = 'install',
     cmd = ' '.join(cmd + ['-a', 'install']),
-    deps = dep + ['//bucklets/tools:mvn'],
     out = 'install.info',
   )
 
@@ -61,6 +58,5 @@
         '-a', 'deploy',
         '--repository', repository,
         '--url', url]),
-      deps = dep + ['//bucklets/tools:mvn'],
       out = 'deploy.info',
     )

tools/BUCK

diff --git a/tools/BUCK b/tools/BUCK
index 4bdfe5a..1983929 100644
--- a/tools/BUCK
+++ b/tools/BUCK
@@ -39,7 +39,6 @@
   name = 'buck.properties',
   cmd = 'echo buck=`which buck`>$OUT;' +
     ("echo PATH=\''%s'\' >>$OUT;" % shquote(os_path())),
-  deps = [],
   out = 'buck.properties',
   visibility = ['PUBLIC'],
 )