commit 98d6e8f01517080706a03e7e8e4f14a1cb2cefa1
author Simon Stewart <simons@fb.com> Wed Oct 09 11:42:33 2013 -0700
committer Michael Bolin <mbolin@fb.com> Fri Oct 11 11:24:24 2013 -0700
tree 2cc2c294c631ece09ce2d32b780133a4e368a7a6
parent 7a32577c3b7b9b082c3edbc63721eacc2f57feab

Clean up temp files if there is no cache result.

Summary:
We create a temp file to uncache files to. However, if we miss the cache entirely, there
is no hit in the cache at all, we leave a zero-length file in the temp directory. Let's
clean that up to avoid cluttering the disk.

Test Plan:
buck test --all
Manually inspect the tmp dir for zero-length zip files

src/com/facebook/buck/rules/AbstractCachingBuildRule.java

diff --git a/src/com/facebook/buck/rules/AbstractCachingBuildRule.java b/src/com/facebook/buck/rules/AbstractCachingBuildRule.java
index 2a1e8f0..ee147f5 100644
--- a/src/com/facebook/buck/rules/AbstractCachingBuildRule.java
+++ b/src/com/facebook/buck/rules/AbstractCachingBuildRule.java
@@ -412,6 +412,7 @@
     // there.
     CacheResult cacheResult = buildInfoRecorder.fetchArtifactForBuildable(zipFile, artifactCache);
     if (!cacheResult.isSuccess()) {
+      zipFile.delete();
       return cacheResult;
     }