commit 8afa1825dfe360d53bf35ef5e5152675828436cd
author Natthu Bharambe <natthu@fb.com> Tue Oct 15 12:52:57 2013 -0700
committer Michael Bolin <mbolin@fb.com> Thu Oct 24 20:58:12 2013 -0700
tree fbbc0ab0e819b176060067e4aa9dd9d12d6e0cc6
parent 5a99962cab7836fac95c86c47da6d84b91c360f0

Remove unnecessary check to strip trailing '/' from native library path.

Summary:
Verified that the check is not needed by changing the if block to:

  if (!nativeLibDir.endsWith("/")) {
    nativeLibDir = nativeLibDir + "/";
  }

src/com/facebook/buck/android/AndroidBinaryRule.java

diff --git a/src/com/facebook/buck/android/AndroidBinaryRule.java b/src/com/facebook/buck/android/AndroidBinaryRule.java
index 2d8fbba..ec26fb9 100644
--- a/src/com/facebook/buck/android/AndroidBinaryRule.java
+++ b/src/com/facebook/buck/android/AndroidBinaryRule.java
@@ -631,10 +631,6 @@
       nativeLibraryDirectories.add(libSubdirectory);
       commands.add(new MakeCleanDirectoryStep(libSubdirectory));
       for (String nativeLibDir : transitiveDependencies.nativeLibsDirectories) {
-        // TODO(mbolin): Verify whether this check is actually necessary. If not, remove it.
-        if (nativeLibDir.endsWith("/")) {
-          nativeLibDir = nativeLibDir.substring(0, nativeLibDir.length() - 1);
-        }
         copyNativeLibrary(nativeLibDir, libSubdirectory, commands);
       }
     }