commit 2281adbfacc2a447d2480107ad9632a86c48eba9
author Jim Purbrick <jimp@fb.com> Wed Nov 13 08:55:50 2013 -0800
committer Michael Bolin <mbolin@fb.com> Sat Nov 16 19:35:09 2013 -0800
tree 7362226bf87d58beaadd2716b3d24ccd5fbf021b
parent 1dfbda5de17953c30aede593a0156458fe5d4f08

Print client disconnection.

Summary:
Print error message on client disconnection. In the normal
case this will never be seen as the client has disconnected, but this
change should help detect suspected false disconnections.

Test Plan: buck test --all

src/com/facebook/buck/cli/Main.java

diff --git a/src/com/facebook/buck/cli/Main.java b/src/com/facebook/buck/cli/Main.java
index f39b8ad..c21b0eb 100644
--- a/src/com/facebook/buck/cli/Main.java
+++ b/src/com/facebook/buck/cli/Main.java
@@ -174,7 +174,7 @@
       return parser;
     }
 
-    private void watchClient(NGContext context) {
+    private void watchClient(final NGContext context) {
       context.addClientListener(new NGClientListener() {
         @Override
         public void clientDisconnected() {
@@ -185,6 +185,8 @@
           // so needs to be left in a consistent state even if the current command is interrupted
           // due to a client disconnection.
           synchronized (parser) {
+            // Client should no longer be connected, but printing helps detect false disconnections.
+            context.err.println("Client disconnected.");
             System.exit(CLIENT_DISCONNECT_EXIT_CODE);
           }
         }