commit | e8160a65a591e602a2fb48953b269dd8d42a7c37 | [log] [tgz] |
---|---|---|
author | Hector Oswaldo Caballero <hector.caballero@ericsson.com> | Fri Jul 28 06:52:24 2017 -0400 |
committer | Hugo Arès <hugo.ares@ericsson.com> | Fri Jul 28 07:29:09 2017 -0400 |
tree | 48580a0db8c117483adcc5d4fd9d81668bdc6b04 | |
parent | b7ff3ce96b5524fba1ec6a6436ad15be3dec3db1 [diff] |
Remove unneeded variable definition When doing list comprehensions predefining the target variable is not necessary. Test plan: * Cleanup generated files: git clean -fdx * Cleanup bazel cache: bazel clean --expunge * Generate project files: tools/eclipse/project.sh * Import project in Eclipse and verify project builds correctly and all artifacts are fetched Change-Id: I0d18c3a327cc0886c1e297ced7d686a4afc7b29a
These build rules are used for building Gerrit Code Review plugins with Bazel. Plugins are compiled as .jar
files containing plugin code and dependencies.
To be able to use the Gerrit rules, you must provide bindings for the plugin API jars. The easiest way to do so is to add the following to your WORKSPACE
file, which will give you default versions for Gerrit plugin API.
git_repository( name = "com_github_davido_bazlets", remote = "https://github.com/davido/bazlets.git", commit = "2ede19cb2d2dd9d04bcb70ffc896439a27e5d50d", ) load("@com_github_davido_bazlets//:gerrit_api.bzl", "gerrit_api")
Another option is to consume snapshot version of gerrit plugin API from local Maven repository (~/.m2
). To use the snapshot version special method is provided:
load("@com_googlesource_gerrit_bazlets//:gerrit_api_maven_local.bzl", "gerrit_api_maven_local") gerrit_api_maven_local()
Suppose you have the following directory structure for a simple plugin:
[workspace]/ WORKSPACE BUILD src/main/java/ src/main/resources/ [...]
To build this plugin, your BUILD
can look like this:
load("//tools/bzl:plugin.bzl", "gerrit_plugin") gerrit_plugin( name = "reviewers", srcs = glob(["src/main/java/**/*.java"]), gwt_module = "com.googlesource.gerrit.plugins.reviewers.ReviewersForm", manifest_entries = [ "Gerrit-PluginName: reviewers", "Gerrit-Module: com.googlesource.gerrit.plugins.reviewers.Module", ], resources = glob(["src/main/**/*"]), )
Now, you can build the Gerrit plugin by running bazel build <plugin>
.
For a real world example, see the reviewers
plugin.
gerrit_plugin(name, srcs, resources, gwt_module, deps, manifest_entries):
<name>.jar
: library containing built plugin jar