| commit | 953edc78cf3b4220402aa05f1d5ddcadd399591f | [log] [tgz] |
|---|---|---|
| author | Ivan Frade <ifrade@google.com> | Mon Jul 01 14:49:32 2019 +0200 |
| committer | Ivan Frade <ifrade@google.com> | Mon Jul 01 14:53:50 2019 +0200 |
| tree | 360f2d0e7a6619bb0e9bda9e7d8aad3636e27e09 | |
| parent | 8528a0df69dadf6311d8d3f81c1b693afda8bcf1 [diff] |
tools/pkg_war.bzl: Use .to_list() on web_xml.files While compiling gitiles, I see this error (edited to fit in commit msg) $ bazel build //:gitiles ERROR: gitiles/BUILD:3:1: in _pkg_war rule //:gitiles: Traceback (most recent call last): File "gitiles/BUILD", line 3 While compiling _pkg_war(name = 'gitiles') File "com_googlesource_gerrit_bazlets/tools/pkg_war.bzl", line 70, in _war_impl for web_xml in ctx.attr.web_xml.files: ... type 'depset' is not iterable. Use the `to_list()` method to get a list. Use --incompatible_depset_is_not_iterable=false to temporarily disable this check. Using to_list() as recommended seems to solve the problem. Change-Id: I6ff428262c6225cb712c709b2df87014e7c98028
These build rules are used for building Gerrit Code Review plugins with Bazel. Plugins are compiled as .jar files containing plugin code and dependencies.
To be able to use the Gerrit rules, you must provide bindings for the plugin API jars. The easiest way to do so is to add the following to your WORKSPACE file, which will give you default versions for Gerrit plugin API.
git_repository( name = "com_github_davido_bazlets", remote = "https://github.com/davido/bazlets.git", commit = "2ede19cb2d2dd9d04bcb70ffc896439a27e5d50d", ) load("@com_github_davido_bazlets//:gerrit_api.bzl", "gerrit_api")
Another option is to consume snapshot version of gerrit plugin API from local Maven repository (~/.m2). To use the snapshot version special method is provided:
load("@com_googlesource_gerrit_bazlets//:gerrit_api_maven_local.bzl", "gerrit_api_maven_local") gerrit_api_maven_local()
Suppose you have the following directory structure for a simple plugin:
[workspace]/
WORKSPACE
BUILD
src/main/java/
src/main/resources/
[...]
To build this plugin, your BUILD can look like this:
load("//tools/bzl:plugin.bzl", "gerrit_plugin") gerrit_plugin( name = "reviewers", srcs = glob(["src/main/java/**/*.java"]), manifest_entries = [ "Gerrit-PluginName: reviewers", "Gerrit-Module: com.googlesource.gerrit.plugins.reviewers.Module", ], resources = glob(["src/main/**/*"]), )
Now, you can build the Gerrit plugin by running bazel build <plugin>.
For a real world example, see the reviewers plugin.
gerrit_plugin(name, srcs, resources, deps, manifest_entries):
<name>.jar: library containing built plugin jar