commit | 62c3c8e0b4b767d1f3b78998ad1aba42a44a9661 | [log] [tgz] |
---|---|---|
author | David Pursehouse <dpursehouse@collab.net> | Mon May 20 13:23:38 2019 +0900 |
committer | David Pursehouse <dpursehouse@collab.net> | Mon May 20 13:23:38 2019 +0900 |
tree | 341833b4e574463176c763246246cd98a90faeb5 | |
parent | 8a96621f0c36fa9d5291377b0c3b63d8a9112848 [diff] |
Fix transitive starlark load for GWT_PLUGIN_DEPS Other GWT_ definitions are not modified because they are not consumed by plugins. This fixes builds on bazel 0.25. Bug: Issue 10855 Change-Id: Ia93e882e5fddea83624944dad5f120664364c2dd
These build rules are used for building Gerrit Code Review plugins with Bazel. Plugins are compiled as .jar
files containing plugin code and dependencies.
To be able to use the Gerrit rules, you must provide bindings for the plugin API jars. The easiest way to do so is to add the following to your WORKSPACE
file, which will give you default versions for Gerrit plugin API.
git_repository( name = "com_github_davido_bazlets", remote = "https://github.com/davido/bazlets.git", commit = "2ede19cb2d2dd9d04bcb70ffc896439a27e5d50d", ) load("@com_github_davido_bazlets//:gerrit_api.bzl", "gerrit_api")
Another option is to consume snapshot version of gerrit plugin API from local Maven repository (~/.m2
). To use the snapshot version special method is provided:
load("@com_googlesource_gerrit_bazlets//:gerrit_api_maven_local.bzl", "gerrit_api_maven_local") gerrit_api_maven_local()
Suppose you have the following directory structure for a simple plugin:
[workspace]/ WORKSPACE BUILD src/main/java/ src/main/resources/ [...]
To build this plugin, your BUILD
can look like this:
load("//tools/bzl:plugin.bzl", "gerrit_plugin") gerrit_plugin( name = "reviewers", srcs = glob(["src/main/java/**/*.java"]), gwt_module = "com.googlesource.gerrit.plugins.reviewers.ReviewersForm", manifest_entries = [ "Gerrit-PluginName: reviewers", "Gerrit-Module: com.googlesource.gerrit.plugins.reviewers.Module", ], resources = glob(["src/main/**/*"]), )
Now, you can build the Gerrit plugin by running bazel build <plugin>
.
For a real world example, see the reviewers
plugin.
gerrit_plugin(name, srcs, resources, gwt_module, deps, manifest_entries):
<name>.jar
: library containing built plugin jar