commit | 0812f520da18fd96b869495003410f2caa3498f9 | [log] [tgz] |
---|---|---|
author | David Ostrovsky <david@ostrovsky.org> | Mon Dec 10 07:41:37 2018 +0100 |
committer | David Pursehouse <dpursehouse@collab.net> | Tue Jan 08 05:43:29 2019 +0000 |
tree | 1d23265e4b8d02316c128542768558b6ba4a197d | |
parent | 09a18a88ebdada986d32c1f50581e8734a47939a [diff] |
Bazel: Update rules_closure to make it forward compatible Gerrit cannot be built any more with upcoming Bazel 0.21 release. That's because rules_closure depends on outdated protobuf version, that uses some Bazel features that were discontinued in upcoming Bazel 0.21 release. Update rules_closure, so that we can upgrade Bazel and build gerrit without passing this incompatible option: --incompatible_package_name_is_a_function=false Bug: Issue 10112 Change-Id: I826471cce7c6a248838a466c458c228eb0a6b5d9
These build rules are used for building Gerrit Code Review plugins with Bazel. Plugins are compiled as .jar
files containing plugin code and dependencies.
To be able to use the Gerrit rules, you must provide bindings for the plugin API jars. The easiest way to do so is to add the following to your WORKSPACE
file, which will give you default versions for Gerrit plugin API.
git_repository( name = "com_github_davido_bazlets", remote = "https://github.com/davido/bazlets.git", commit = "2ede19cb2d2dd9d04bcb70ffc896439a27e5d50d", ) load("@com_github_davido_bazlets//:gerrit_api.bzl", "gerrit_api")
Another option is to consume snapshot version of gerrit plugin API from local Maven repository (~/.m2
). To use the snapshot version special method is provided:
load("@com_googlesource_gerrit_bazlets//:gerrit_api_maven_local.bzl", "gerrit_api_maven_local") gerrit_api_maven_local()
Suppose you have the following directory structure for a simple plugin:
[workspace]/ WORKSPACE BUILD src/main/java/ src/main/resources/ [...]
To build this plugin, your BUILD
can look like this:
load("//tools/bzl:plugin.bzl", "gerrit_plugin") gerrit_plugin( name = "reviewers", srcs = glob(["src/main/java/**/*.java"]), gwt_module = "com.googlesource.gerrit.plugins.reviewers.ReviewersForm", manifest_entries = [ "Gerrit-PluginName: reviewers", "Gerrit-Module: com.googlesource.gerrit.plugins.reviewers.Module", ], resources = glob(["src/main/**/*"]), )
Now, you can build the Gerrit plugin by running bazel build <plugin>
.
For a real world example, see the reviewers
plugin.
gerrit_plugin(name, srcs, resources, gwt_module, deps, manifest_entries):
<name>.jar
: library containing built plugin jar