commit | cb66cc0c8e11fcdc848c4606f1f1ef3354649155 | [log] [tgz] |
---|---|---|
author | David Pursehouse <dpursehouse@collab.net> | Fri Feb 17 10:46:58 2017 +0900 |
committer | David Pursehouse <dpursehouse@collab.net> | Fri Feb 17 10:54:58 2017 +0900 |
tree | 381385f80a2687b8fb74e7932a74cad513135503 | |
parent | 0f87babe07a555425d829c6e7951e296e9e24579 [diff] |
gerrit_plugin: Don't add Implementation-Vendor manifest entry If a plugin specifies Implementation-Vendor, adding it again in the gerrit_plugin rule results in a duplicate entry and the following warning at build time: WARNING: Duplicate name in Manifest: Implementation-Vendor. Ensure that the manifest does not have duplicate entries, and that blank lines separate individual sections in both your manifest and in the META-INF/MANIFEST.MF entry in the jar file. Change-Id: Icb072803355677c42383b8177b073abee0708b30
These build rules are used for building Gerrit Code Review plugins with Bazel. Plugins are compiled as .jar
files containing plugin code and dependencies.
To be able to use the Gerrit rules, you must provide bindings for the plugin API jars. The easiest way to do so is to add the following to your WORKSPACE
file, which will give you default versions for Gerrit plugin API.
git_repository( name = "com_github_davido_bazlets", remote = "https://github.com/davido/bazlets.git", commit = "2ede19cb2d2dd9d04bcb70ffc896439a27e5d50d", ) load("@com_github_davido_bazlets//:gerrit_api.bzl", "gerrit_api")
Another option is to consume snapshot version of gerrit plugin API from local Maven repository (~/.m2
). To use the snapshot version special method is provided:
load("@com_googlesource_gerrit_bazlets//:gerrit_api_maven_local.bzl", "gerrit_api_maven_local") gerrit_api_maven_local()
Suppose you have the following directory structure for a simple plugin:
[workspace]/ WORKSPACE BUILD src/main/java/ src/main/resources/ [...]
To build this plugin, your BUILD
can look like this:
load("//tools/bzl:plugin.bzl", "gerrit_plugin") gerrit_plugin( name = "reviewers", srcs = glob(["src/main/java/**/*.java"]), gwt_module = "com.googlesource.gerrit.plugins.reviewers.ReviewersForm", manifest_entries = [ "Gerrit-PluginName: reviewers", "Gerrit-Module: com.googlesource.gerrit.plugins.reviewers.Module", ], resources = glob(["src/main/**/*"]), )
Now, you can build the Gerrit plugin by running bazel build <plugin>
.
For a real world example, see the reviewers
plugin.
gerrit_plugin(name, srcs, resources, gwt_module, deps, manifest_entries):
<name>.jar
: library containing built plugin jar