Set minSdkVersion to 17 (Android 4.2) Android 4.2 supports nested fragments [1]. This will allow us to use a ViewPager within a Fragment. At the moment 10% of the Android devices run with an SDK version >= 14 and <= 17 [2]. Considering that the app is only used by developers and developers tend to have new devices with latest updates it should be OK to increase the minSdkVersion to 17 and thus removing support for this 10% of Android devices. [1] http://developer.android.com/about/versions/android-4.2.html#NestedFragments [2] http://developer.android.com/about/dashboards/index.html#Platform Change-Id: Ic08b5761ec961ec6cbb92901908067f64a149d01 Signed-off-by: Edwin Kempin <ekempin@google.com>
diff --git a/app/build.gradle b/app/build.gradle index 9090a8a..3d75bb6 100644 --- a/app/build.gradle +++ b/app/build.gradle
@@ -7,7 +7,7 @@ defaultConfig { applicationId 'com.google.reviewit' - minSdkVersion 14 + minSdkVersion 17 targetSdkVersion 23 versionCode 1 versionName '1.0'
diff --git a/app/src/main/java/com/google/reviewit/ServerListFragment.java b/app/src/main/java/com/google/reviewit/ServerListFragment.java index 2df4757..2f1d708 100644 --- a/app/src/main/java/com/google/reviewit/ServerListFragment.java +++ b/app/src/main/java/com/google/reviewit/ServerListFragment.java
@@ -99,8 +99,7 @@ widgetUtil.dpToPx(20), widgetUtil.dpToPx(20)); layoutParams.setMargins(0, 0, widgetUtil.dpToPx(5), 0); icon.setLayoutParams(layoutParams); - // TODO use setBackGround(Drawable) with API 16 - icon.setBackgroundDrawable(widgetUtil.getDrawable(drawableId)); + icon.setBackground(widgetUtil.getDrawable(drawableId)); icon.setOnClickListener(onClickListener); return icon; }
diff --git a/app/src/main/java/com/google/reviewit/util/WidgetUtil.java b/app/src/main/java/com/google/reviewit/util/WidgetUtil.java index 374c9f9..270230d 100644 --- a/app/src/main/java/com/google/reviewit/util/WidgetUtil.java +++ b/app/src/main/java/com/google/reviewit/util/WidgetUtil.java
@@ -143,8 +143,7 @@ } public static void setBackground(View view, Drawable drawable) { - // TODO use setBackGround(Drawable) with API 16 - view.setBackgroundDrawable(drawable); + view.setBackground(drawable); } public static void setXY(View view, int x, int y) {