commit 8dc63722095413089467821b759b82bc16bcd5aa
author Christoforos Miliotis <christoforos.miliotis.dev@gmail.com> Wed Oct 25 15:28:11 2023 +0100
committer Christoforos Miliotis <christoforos.miliotis.dev@gmail.com> Mon Nov 06 13:27:32 2023 +0000
tree 9e6031d0dd23b8fc1e7f0728b041ba53933b2381
parent 41469da66015d740136672b1d15ef31aa83c648b

Enrich logging message with ref's new value

Add the ref's new value when logging exception while executing the
`compareAndPut` method. This will make the log more useful when trying
to debug split brain situations.

Bug: Issue 300831672
Change-Id: Id55d425cda298b300eecf4a5929b6a78c90768be

src/main/java/com/gerritforge/gerrit/globalrefdb/validation/RefUpdateValidator.java

diff --git a/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/RefUpdateValidator.java b/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/RefUpdateValidator.java
index ec8ff82..d955599 100644
--- a/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/RefUpdateValidator.java
+++ b/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/RefUpdateValidator.java
@@ -225,8 +225,8 @@
               Project.nameKey(projectName), refPair.compareRef, refPair.putValue);
     } catch (GlobalRefDbSystemError e) {
       logger.atWarning().withCause(e).log(
-          "Not able to persist the data in global-refdb for project '%s' and ref '%s', message: %s",
-          projectName, refPair.getName(), e.getMessage());
+          "Not able to persist the data in global-refdb for project '%s', ref '%s' and value %s, message: %s",
+          projectName, refPair.getName(), refPair.putValue, e.getMessage());
       throw e;
     }