Log lock acquisition only after is successful
The logging of the acquired locks was performed well before the lock
method call causing misleading output in the log and leading the reader
to think that the lock had been acquired, but that wasn't the case.
Change-Id: Iebe81dd81d64b4bccee812b301865fb7511ee71c
diff --git a/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/LockWrapper.java b/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/LockWrapper.java
index a1312b0..489a833 100644
--- a/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/LockWrapper.java
+++ b/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/LockWrapper.java
@@ -51,6 +51,7 @@
this.sharedRefLogger = sharedRefLogger;
this.project = project;
this.refName = refName;
+ sharedRefLogger.logLockAcquisition(project, refName);
}
/**
diff --git a/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/SharedRefDatabaseWrapper.java b/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/SharedRefDatabaseWrapper.java
index 0cddb0a..d89e535 100644
--- a/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/SharedRefDatabaseWrapper.java
+++ b/src/main/java/com/gerritforge/gerrit/globalrefdb/validation/SharedRefDatabaseWrapper.java
@@ -122,7 +122,6 @@
public AutoCloseable lockRef(Project.NameKey project, String refName)
throws GlobalRefDbLockException {
try (Context context = metrics.startLockRefExecutionTime()) {
- sharedRefLogger.logLockAcquisition(project.get(), refName);
return new LockWrapper(
sharedRefLogger, project.get(), refName, sharedRefDb().lockRef(project, refName));
}
