| commit | 546b777103303f89792cae27a7de2b5f07f20574 | [log] [tgz] |
|---|---|---|
| author | Antonio Barone <syntonyze@gmail.com> | Mon Jan 03 15:09:09 2022 +0100 |
| committer | Antonio Barone <syntonyze@gmail.com> | Tue Jan 04 15:07:47 2022 +0100 |
| tree | 3e4cf00411631cb4651b2525be0dd1e2a76fe180 | |
| parent | ec6956dac5c5ebcc9212ad1a54c777e737a2baf5 [diff] |
Introduce cache for open changes Git-refs-filter plugin relies on change_notes when filtering for open changes. In order to speed up access to them, it is advised to enable caching for change_notes, as documented in the README.md. Whilst this improves the _accessing_ of the change note, it does nothing to speed up the parsing of the change itself, in order to gather the change status information, needed to assess whether the change is actually open. Introduce an additional in-memory cache to store previously computed open/close change statuses to avoid processing them over and over again. Explicit cache invalidation is not necessary, since the change revision is part of the cache key, so that previous entries automatically become obsolete once a change status is updated. Bug: Issue 15484 Change-Id: I36467dbd7c1ce646d97be410acbae564fa4a675f
Gerrit lib module to allow filtering out refs in the Git advertizing protocol phase.
Gerrit ACLs, Git's hideRefs and git-refs-filter are all tools for hiding refs from being visible to a remote Git client. However, the three tools have different scope and performance implications.
Use the Git's hideRefs when all Git clients need to be blocked from accessing some refs.
This method to hide refs is the fastest possible and has no performance implications.
The git-refs-filter is mostly used with CI systems to avoid the overloading of advertising and downloading a significant number of refs that would slowdown both Gerrit server and the Git client.
It is more flexible than Git‘s hideRefs because allows to define a limited group of users for hiding refs; it also allows to filter Gerrit NoteDb’s /meta refs which would otherwise require a complex set of ACLs or plugins.
git-refs-filter is slightly slower than using Git's hideRefs and it does require the configuration of the change_notes cache in gerrit.config to avoid potentially high overhead.
Additionally, this plugin uses an in-memory cache to store previously computed open/close change statuses to avoid processing them over and over again.
Explicit invalidation of such cache is not necessary, since the change revision is part of the cache key, so that previous entries automatically become obsolete once a change status is updated.
Use the Gerrit ACLs when you need to hide some of the refs on a per-project basis or when it is needed a very sophisticated pattern-matching of refs to be excluded.
This is the slowest way to hide refs and needs to be used only when a per-project ACLs policy is required.
Build this module as it was a Gerrit plugin:
git-refs-filter directory to Gerrit /plugins/git-refs-filterbazel build plugins/git-refs-filterbazel test plugins/git-refs-filter:git_refs_filter_testsgit-refs-filter.jar module is generated under /bazel-genfiles/plugins/git-refs-filter/Copy git-refs-filter.jar library to Gerrit /lib and add the following one extra settings to gerrit.config:
[gerrit] installModule = com.googlesource.gerrit.modules.gitrefsfilter.RefsFilterModule
The refsfilter module defines a new global capability called “Filter out closed changes refs”. By default the capability isn't assigned to any user or group, thus the module installation has no side effects.
Filtering a closed change refs has the following meaning:
It is also possible to define additional refs prefixes to be hidden or explicitly shown, using a similar syntax to the hideRefs setting, adding a set of git-refs-filter.hideRefs configuration settings in gerrit.config.
Example of how to hide all refs/backup/* and refs/sandbox/* from being advertised but still show refs/sandbox/mines/:
[git-refs-filter] hideRefs = refs/backup/ hideRefs = refs/sandbox/ hideRefs = !refs/sandbox/mine/ ``` To enable a group of users of getting a "filtered list" of refs (e.g. CI jobs): - Define a new group of users (e.g. Builders) - Add a user to that group (e.g. Add 'jenkins' to the Builders group) - Go to the All-Projects ACLs, add the "Filter out closed changes refs" and assign to the group (e.g. Builders) *NOTE* Gerrit makes a super-simplified ACL evaluation if all the projects are globally readable (e.g. project has a READ rule to refs/*). To enable the closed changes filtering you need to disable any global read rule for the group that needs refs filtering.