Fix NPE thrown by LRU Cache

When attempting to remove a non-existing entry from the LRU cache, the
underlying synchronized map will return 'null' rather than a Boolean.

The attempt to unbox 'null' as a primitive boolean was causing an NPE
to be thrown.

Fix this by changing the return type of the remove() method to Boolean.

Bug: Issue 14099
Change-Id: If4aca686ed0fe1e4ccc2ad58deb50694a343dc38
2 files changed
tree: 7395e2536e311ef24eb90eff98b7b787f05470ff
  1. src/
  2. .gitignore
  3. BUILD
  4. external_plugin_deps.bzl
  5. Jenkinsfile
  6. LICENSE
  7. README.md
README.md

Persistent cache for Gerrit, based on ChronicleMap

Non-blocking and super-fast on-disk cache libModule for Gerrit Code Review based on ChronicleMap on-disk implementation.

How to build

This libModule is built like a Gerrit in-tree plugin, using Bazelisk. See the build instructions for more details.

Setup

  • Install cache-chronicalmap module

Install the chronicle-map module into the $GERRIT_SITE/lib directory.

Add the cache-chroniclemap module to $GERRIT_SITE/etc/gerrit.config as follows:

[gerrit]
  installModule = com.googlesource.gerrit.modules.cache.chroniclemap.ChronicleMapCacheModule

For further information and supported options, refer to config documentation.

Migration from H2 caches

You can check how to migrate from H2 to chronicle-map here.