| commit | c27f65e6093e84e3a4ccb9f5d759e98c1f1f4a48 | [log] [tgz] |
|---|---|---|
| author | Jack Rosenthal <jrosenth@chromium.org> | Tue Feb 13 14:46:25 2024 -0700 |
| committer | Jack Rosenthal <jrosenth@chromium.org> | Tue Feb 13 14:46:25 2024 -0700 |
| tree | af003f306f2952340027d5fd48ffd0d53ff43658 | |
| parent | 3ad19978a3149e7ae5bebd2ddbdf26252ec16e89 [diff] |
DevServer: Fix compilation error for getUserKey
I got a compilation error while trying to run run_dev.sh:
% ~/gitiles/tools/run_dev.sh
INFO: Invocation ID: 45647a11-06cb-40c8-a9bd-cae61c5802c0
INFO: Analyzed target //java/com/google/gitiles/dev:dev (0 packages loaded, 0 targets configured).
ERROR: /home/jrosenth/gitiles/java/com/google/gitiles/dev/BUILD:3:13: Building java/com/google/gitiles/dev/liblib.jar (2 source files) failed: (Exit 1): java failed: error executing Javac command (from target //java/com/google/gitiles/dev:lib) external/remotejdk21_linux/bin/java '--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED' '--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED' ... (remaining 19 arguments skipped)
java/com/google/gitiles/dev/DevServer.java:215: error: [ReturnMissingNullable] Method returns a definitely null value but is not annotated @Nullable
return null;
^
(see https://errorprone.info/bugpattern/ReturnMissingNullable)
Did you mean 'public @Nullable Object getUserKey() {'?
Target //java/com/google/gitiles/dev:dev failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 3.255s, Critical Path: 3.18s
INFO: 3 processes: 2 internal, 1 linux-sandbox.
ERROR: Build did NOT complete successfully
There appears to be no negative consequence to using an empty string
here instead, so change to that.
Change-Id: I86f574c89e351e649f6d9d6cd19582cb560f9b28
Gitiles is a simple repository browser for Git repositories, built on JGit. Its guiding principle is simplicity: it has no formal access controls, no write access, no fancy Javascript, etc.
Gitiles automatically renders *.md Markdown files into HTML for simplified documentation. Refer to the Markdown documentation for details.
Gitiles is configurable in a git-style configuration file named gitiles.config. Refer to the configuration documentation for details.
Use the issue tracker at github to file bugs.
Please refer to the Developer Guide.