manifest: normalize name & path when constructing fs paths

If the manifest uses a trailing slash on the name attribute, repo
will construct bad internal filesystem paths which confuses tools
later on.

For example, this manifest entry:
  <project name="aosp/platform/system/libhidl/" ...
will cause repo to use paths like:
  .repo/project-objects/aosp/platform/system/libhidl/.git/
when it really should be using:
  .repo/project-objects/aosp/platform/system/libhidl.git

Apply the normalization when we construct the local filesystem paths
as we cannot guarantee that the remote URL constructed from these
will behave the same.  A server might really want:
  https://example.com/aosp/platform/system/libhidl/
and would throw an error if we instead tried to fetch:
  https://example.com/aosp/platform/system/libhidl

Unfortunately, any existing repo client checkouts that use such a
manifest will hit a one-time sync error as the internal git location
has changed.  I'm not sure there's a way to cleanly migrate that.

Bug: https://crbug.com/1086043
Change-Id: I30bea0ffd23e478de89a035f408055e48a102658
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/268742
Tested-by: Mike Frysinger <vapier@google.com>
Reviewed-by: David Pursehouse <dpursehouse@digital.ai>
1 file changed
tree: 8b175284dd58b3ae0313cdba91083a47458705db
  1. .flake8
  2. .gitattributes
  3. .github/
  4. .gitignore
  5. .mailmap
  6. .project
  7. .pydevproject
  8. LICENSE
  9. MANIFEST.in
  10. README.md
  11. SUBMITTING_PATCHES.md
  12. color.py
  13. command.py
  14. docs/
  15. editor.py
  16. error.py
  17. event_log.py
  18. git_command.py
  19. git_config.py
  20. git_refs.py
  21. git_ssh
  22. gitc_utils.py
  23. hooks/
  24. main.py
  25. manifest_xml.py
  26. pager.py
  27. platform_utils.py
  28. platform_utils_win32.py
  29. progress.py
  30. project.py
  31. pyversion.py
  32. release/
  33. repo
  34. repo_trace.py
  35. run_tests
  36. setup.py
  37. subcmds/
  38. tests/
  39. tox.ini
  40. wrapper.py
README.md

repo

Repo is a tool built on top of Git. Repo helps manage many Git repositories, does the uploads to revision control systems, and automates parts of the development workflow. Repo is not meant to replace Git, only to make it easier to work with Git. The repo command is an executable Python script that you can put anywhere in your path.

Contact

Please use the repo-discuss mailing list or issue tracker for questions.

You can file a new bug report under the “repo” component.

Please do not e-mail individual developers for support. They do not have the bandwidth for it, and often times questions have already been asked on repo-discuss or bugs posted to the issue tracker. So please search those sites first.

Install

Many distros include repo, so you might be able to install from there.

# Debian/Ubuntu.
$ sudo apt-get install repo

# Gentoo.
$ sudo emerge dev-vcs/repo

You can install it manually as well as it's a single script.

$ mkdir -p ~/.bin
$ PATH="${HOME}/.bin:${PATH}"
$ curl https://storage.googleapis.com/git-repo-downloads/repo > ~/.bin/repo
$ chmod a+rx ~/.bin/repo