Google Git
Sign in
gerrit / git-repo / a00c5f40e76fd520597013ae89823711212630b3
commita00c5f40e76fd520597013ae89823711212630b3[log] [tgz]
authorMike Frysinger <vapier@google.com>Thu Feb 25 18:26:31 2021 -0500
committerMike Frysinger <vapier@google.com>Sun Feb 28 16:07:12 2021 +0000
tree44d9536431bc7e63e3855e3b628cbdf4ab6544fc
parent6093d99d13deada12a2365e81e2bd148dbb423ad [diff]
manifest: refactor the filesystem checking logic for more reuse

This function is currently written with copyfile & linkfile in mind.
Generalize the logic & function arguments slightly so we can reuse
in more places that make sense.

This changes the validation logic slightly too in that we no longer
allow "." for the dest attribute with copyfile & linkfile, nor for
the src attribute with copyfile.  We already rejected those later on
when checking against the active filesystem, but now we reject them
a little sooner when parsing.

The empty path check isn't a new requirement exactly -- repo used to
crash on it, so it was effectively blocked, but now we diagnosis it.

Bug: https://crbug.com/gerrit/14156
Change-Id: I0fdb42a3da60ed149ff1997c5dd4b85da70eec3d
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/298442
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Tested-by: Mike Frysinger <vapier@google.com>
2 files changed
tree: 44d9536431bc7e63e3855e3b628cbdf4ab6544fc
  1. .github/
  2. docs/
  3. hooks/
  4. release/
  5. subcmds/
  6. tests/
  7. .flake8
  8. .gitattributes
  9. .gitignore
  10. .mailmap
  11. .project
  12. .pydevproject
  13. color.py
  14. command.py
  15. editor.py
  16. error.py
  17. event_log.py
  18. git_command.py
  19. git_config.py
  20. git_refs.py
  21. git_ssh
  22. git_superproject.py
  23. git_trace2_event_log.py
  24. gitc_utils.py
  25. hooks.py
  26. LICENSE
  27. main.py
  28. MANIFEST.in
  29. manifest_xml.py
  30. pager.py
  31. platform_utils.py
  32. platform_utils_win32.py
  33. progress.py
  34. project.py
  35. README.md
  36. repo
  37. repo_trace.py
  38. requirements.json
  39. run_tests
  40. setup.py
  41. SUBMITTING_PATCHES.md
  42. tox.ini
  43. wrapper.py
README.md

repo

Repo is a tool built on top of Git. Repo helps manage many Git repositories, does the uploads to revision control systems, and automates parts of the development workflow. Repo is not meant to replace Git, only to make it easier to work with Git. The repo command is an executable Python script that you can put anywhere in your path.

Contact

Please use the repo-discuss mailing list or issue tracker for questions.

You can file a new bug report under the “repo” component.

Please do not e-mail individual developers for support. They do not have the bandwidth for it, and often times questions have already been asked on repo-discuss or bugs posted to the issue tracker. So please search those sites first.

Install

Many distros include repo, so you might be able to install from there.

# Debian/Ubuntu.
$ sudo apt-get install repo

# Gentoo.
$ sudo emerge dev-vcs/repo

You can install it manually as well as it's a single script.

$ mkdir -p ~/.bin
$ PATH="${HOME}/.bin:${PATH}"
$ curl https://storage.googleapis.com/git-repo-downloads/repo > ~/.bin/repo
$ chmod a+rx ~/.bin/repo