Google Git
Sign in
gerrit / git-repo / 7393f6bc414ae5d140101fffcb48148a36b80f64
commit7393f6bc414ae5d140101fffcb48148a36b80f64[log] [tgz]
authorChris Allen <chris.allen@arm.com>Fri Oct 20 16:35:39 2023 +0100
committerLUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 20 18:22:59 2023 +0000
tree636b5fc909145e85e7e0ab160b8241287ae6cbf0
parent8dd85218541f66b5c6740e46ebb3ebbcfc585af1 [diff]
manifest_xml: Fix empty project list when DOCTYPE is present

When parsing the manifest XML, the code looks for a top
level DOM node named "manifest". However, it doesn't check
that it's an element type node so if there is also an XML
document type declaration node present (which has the same
name as the root element) then it selects the wrong node
and hence you end up with no projects defined at all.

Change-Id: I8d101caffbbc2a06e56136ff21302e3f09cfc96b
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/390357
Reviewed-by: Mike Frysinger <vapier@google.com>
Tested-by: Chris Allen <chris.allen@arm.com>
Commit-Queue: Chris Allen <chris.allen@arm.com>
2 files changed
tree: 636b5fc909145e85e7e0ab160b8241287ae6cbf0
  1. .github/
  2. docs/
  3. hooks/
  4. man/
  5. release/
  6. subcmds/
  7. tests/
  8. .flake8
  9. .gitattributes
  10. .gitignore
  11. .gitreview
  12. .isort.cfg
  13. .mailmap
  14. .project
  15. .pydevproject
  16. color.py
  17. command.py
  18. completion.bash
  19. editor.py
  20. error.py
  21. event_log.py
  22. fetch.py
  23. git_command.py
  24. git_config.py
  25. git_refs.py
  26. git_ssh
  27. git_superproject.py
  28. git_trace2_event_log.py
  29. git_trace2_event_log_base.py
  30. hooks.py
  31. LICENSE
  32. main.py
  33. MANIFEST.in
  34. manifest_xml.py
  35. pager.py
  36. platform_utils.py
  37. platform_utils_win32.py
  38. progress.py
  39. project.py
  40. pyproject.toml
  41. README.md
  42. repo
  43. repo_logging.py
  44. repo_trace.py
  45. requirements.json
  46. run_tests
  47. run_tests.vpython3
  48. setup.py
  49. ssh.py
  50. SUBMITTING_PATCHES.md
  51. tox.ini
  52. wrapper.py
README.md

repo

Repo is a tool built on top of Git. Repo helps manage many Git repositories, does the uploads to revision control systems, and automates parts of the development workflow. Repo is not meant to replace Git, only to make it easier to work with Git. The repo command is an executable Python script that you can put anywhere in your path.

Contact

Please use the repo-discuss mailing list or issue tracker for questions.

You can file a new bug report under the “repo” component.

Please do not e-mail individual developers for support. They do not have the bandwidth for it, and often times questions have already been asked on repo-discuss or bugs posted to the issue tracker. So please search those sites first.

Install

Many distros include repo, so you might be able to install from there.

# Debian/Ubuntu.
$ sudo apt-get install repo

# Gentoo.
$ sudo emerge dev-vcs/repo

You can install it manually as well as it's a single script.

$ mkdir -p ~/.bin
$ PATH="${HOME}/.bin:${PATH}"
$ curl https://storage.googleapis.com/git-repo-downloads/repo > ~/.bin/repo
$ chmod a+rx ~/.bin/repo