Google Git
Sign in
gerrit / git-repo / 70c54dc2550084ed022a2f134065a011f37f30aa
commit70c54dc2550084ed022a2f134065a011f37f30aa[log] [tgz]
authorMike Frysinger <vapier@google.com>Fri Nov 15 01:19:03 2019 -0500
committerMike Frysinger <vapier@google.com>Sat Nov 16 23:55:30 2019 +0000
tree6086cb67a1b1f928892b4d47d1b77a069b5ae31f
parent6da17751ca4e3b90834ca763f448ddc39b32651b [diff]
upload/editor: fix bytes/string confusion

The upload module tries to turn the strings into bytes before passing
to EditString, but it combines bytes & strings causing an error.  The
return value might be bytes or string, but the caller only expects a
string.  Lets simplify this by sticking to strings everywhere and have
EditString take care of converting to/from bytes when reading/writing
the underlying files.  This also avoids possible locale confusion when
reading the file by forcing UTF-8 everywhere.

Bug: https://crbug.com/gerrit/11929
Change-Id: I07b146170c5e8b5b0500a2c79e4213cd12140a96
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/245621
Reviewed-by: David Pursehouse <dpursehouse@collab.net>
Tested-by: Mike Frysinger <vapier@google.com>
3 files changed
tree: 6086cb67a1b1f928892b4d47d1b77a069b5ae31f
  1. docs/
  2. hooks/
  3. subcmds/
  4. tests/
  5. .flake8
  6. .gitattributes
  7. .gitignore
  8. .mailmap
  9. .project
  10. .pydevproject
  11. color.py
  12. command.py
  13. COPYING
  14. editor.py
  15. error.py
  16. event_log.py
  17. git_command.py
  18. git_config.py
  19. git_refs.py
  20. git_ssh
  21. gitc_utils.py
  22. main.py
  23. manifest_xml.py
  24. pager.py
  25. platform_utils.py
  26. platform_utils_win32.py
  27. progress.py
  28. project.py
  29. pyversion.py
  30. README.md
  31. repo
  32. repo_trace.py
  33. run_tests
  34. SUBMITTING_PATCHES.md
  35. wrapper.py
README.md

repo

Repo is a tool built on top of Git. Repo helps manage many Git repositories, does the uploads to revision control systems, and automates parts of the development workflow. Repo is not meant to replace Git, only to make it easier to work with Git. The repo command is an executable Python script that you can put anywhere in your path.