| commit | 2b7daff8cb0bb6a0836ca0cbc18f7f86b5eb0c86 | [log] [tgz] |
|---|---|---|
| author | Pierre Tardy <tardyp@gmail.com> | Thu May 16 10:28:21 2019 +0200 |
| committer | Mike Frysinger <vapier@google.com> | Thu Jul 11 01:33:37 2019 +0000 |
| tree | 5a8e37a0b86696dff8abbe2f380f4b0b70f30892 | |
| parent | 242fcdd93b461263a1322093d432427736cf7e41 [diff] |
Don't try to decode when checking clone bundles
This fix exception with python3 with stack-trace:
error: Cannot fetch platform_external_grpc-grpc-java.git (UnicodeDecodeError: 'utf-8' codec can't decode byte 0x96 in position 640: invalid start byte)
[...]
File "[...]project.py", line 2255, in _IsValidBundle
if f.read(16) == '# v2 git bundle\n':
File "/usr/lib/python3.5/codecs.py", line 321, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
Even if we ask 16 characters, python buffered decoder will try to decode more in the buffer
The patch works for python2 and python3, and open the file in byte mode so that decoding is not attemped
Signed-off-by: Pierre Tardy <tardyp@gmail.com>
Change-Id: I837ae3c5cd724b34670fc2a84e853431f482b20d
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/224642
Reviewed-by: Mike Frysinger <vapier@google.com>
Reviewed-by: David Pursehouse <dpursehouse@collab.net>
Tested-by: Mike Frysinger <vapier@google.com>
Repo is a tool built on top of Git. Repo helps manage many Git repositories, does the uploads to revision control systems, and automates parts of the development workflow. Repo is not meant to replace Git, only to make it easier to work with Git. The repo command is an executable Python script that you can put anywhere in your path.