| commit | 681fabaeddd5c8595b8806749a431dfb7db7c981 | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Mon Mar 14 19:15:41 2022 +0100 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Thu Apr 14 13:32:24 2022 +0000 |
| tree | e00815858101c7af604341f6e32b07ee4706a4b9 | |
| parent | f2f136ffe975cae93aac627929ba72ff013a1b42 [diff] |
ChangeUpdate: fix updating change meta ref when the update is no/op There was a bug in RemoveAttentionSetOp in the sense that it always returned true signalling to callers to perform an update regardless of whether the attention set will get updated or not. At the time we build the change meta ref commit, we append all updates to the commit message. The method ChangeUpdate#isEmpty checks if there are no updates and bails out at [1]. Sometimes the variable plannedAttentionSetUpdates contained some updates, but this variable is processed in [2] while writing the commit message and in some cases no updates are written after all. This triggered the creation of a new commit in the change meta ref which is redundant, hence fixing in this change and adapting the test in PostReviewIT to ensure the change meta ref is not updated in this case. We fix this by factoring out plannedAttentionSetUpdates from #isEmpty and explicitly checking that [2] did not include any attention set updates. We do that because #isEmpty is also called from [3] in AbstractChangeUpdate#apply (at the beginning of the processing) and it bails out quickly if plannedAttentionSetUpdates is null. [1] https://gerrit.googlesource.com/gerrit/+/23678de2cdc56b676fcd80ea5d76b10af8c77304/java/com/google/gerrit/server/notedb/ChangeUpdate.java#1085 [2] https://gerrit.googlesource.com/gerrit/+/23678de2cdc56b676fcd80ea5d76b10af8c77304/java/com/google/gerrit/server/notedb/ChangeUpdate.java#984 [3] https://gerrit.googlesource.com/gerrit/+/23678de2cdc56b676fcd80ea5d76b10af8c77304/java/com/google/gerrit/server/notedb/AbstractChangeUpdate.java#220 Release-Notes: skip Google-Bug-Id: b/221124220 Change-Id: I4086c614ff670e3bc43f772c3d004c65477db4eb (cherry picked from commit ecf033e5ef52eab3b0a8d4d6aef9d2799a467020)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.