Ensure no ambiguous change IDs when deleting in the index.changes api When deleteMissing is true, changes are potentially deleted from the index, it's therefore crucial that we do not use an ambiguous change-id formats that could lead to Gerrit deleting the wrong change from the index. This api essentially used a side-effect of ChangeFinder to identify if a change was present or not: - ChangeFinder uses the index to find the document if the identifier isn't a `project~changeNumber` - If the entry is found on the index, it then tries to load the associated NoteDb data from the Git repository - If the data is present in the index but NOT in NoteDb, then it returns an empty result The above doesn't happen if the change is in `project~changeNumber` format. The code was relying on the above logic to infer that a change was in the index, but not in NoteDb, by checking if the result was empty, which is a side-effect rather than a direct contract behaviour. Use the queryProvider to identify if a change is present in the index or not, and, if it is, check on disk if it's actually present. To ensure we don't use ambiguous changeIDs, force using project~changeNum as its the true unique identifier of a change. Finally, fail the request with a 400 status code if not all change ids are in said format. Release-Notes: Breaking change: require tilde changeIds in config/server/index.changes when requesting deletions and reject legacy numeric-only ids. Bug: Issue 515272357 Change-Id: I8350971af868ee34b17fc8703aa9ef40c03f5ec5
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.