Merge "Add spacing below check result header and align tags."
diff --git a/polygerrit-ui/app/elements/checks/gr-checks-results.ts b/polygerrit-ui/app/elements/checks/gr-checks-results.ts
index cf9b85f..ef163b4 100644
--- a/polygerrit-ui/app/elements/checks/gr-checks-results.ts
+++ b/polygerrit-ui/app/elements/checks/gr-checks-results.ts
@@ -767,6 +767,9 @@
.ai-generated {
font-weight: var(--font-weight-medium);
}
+ .header-content {
+ margin-bottom: var(--spacing-m);
+ }
`,
];
}
@@ -774,9 +777,11 @@
override render() {
if (!this.result) return '';
return html`
- ${this.renderFirstPrimaryLink()} ${this.renderOtherPrimaryLinks()}
- ${this.renderSecondaryLinks()} ${this.renderCodePointers()}
- ${this.renderAiLabel()}
+ <div class="header-content">
+ ${this.renderFirstPrimaryLink()} ${this.renderOtherPrimaryLinks()}
+ ${this.renderSecondaryLinks()} ${this.renderCodePointers()}
+ ${this.renderAiLabel()}
+ </div>
<gr-endpoint-decorator
name="check-result-expanded"
.targetPlugin=${this.result.pluginName}
diff --git a/polygerrit-ui/app/elements/checks/gr-checks-results_test.ts b/polygerrit-ui/app/elements/checks/gr-checks-results_test.ts
index 3face0a..df027c9 100644
--- a/polygerrit-ui/app/elements/checks/gr-checks-results_test.ts
+++ b/polygerrit-ui/app/elements/checks/gr-checks-results_test.ts
@@ -161,86 +161,88 @@
assert.shadowDom.equal(
element,
/* HTML */ `
- <div class="links">
- <a
- href="https://google.com"
- rel="noopener noreferrer"
- target="_blank"
- >
- <gr-icon class="link" icon="download"> </gr-icon>
- <span> Download </span>
- </a>
- <a
- href="https://google.com"
- rel="noopener noreferrer"
- target="_blank"
- >
- <gr-icon class="link" icon="system_update"> </gr-icon>
- <span> Download </span>
- </a>
- <a
- href="https://google.com"
- rel="noopener noreferrer"
- target="_blank"
- >
- <gr-icon class="link" filled="" icon="image"> </gr-icon>
- <span> Link to image </span>
- </a>
- <a
- href="https://google.com"
- rel="noopener noreferrer"
- target="_blank"
- >
- <gr-icon class="link" filled="" icon="image"> </gr-icon>
- <span> Link to image </span>
- </a>
- <a
- href="https://google.com"
- rel="noopener noreferrer"
- target="_blank"
- >
- <gr-icon class="link" filled="" icon="bug_report"> </gr-icon>
- <span> Link for reporting a problem </span>
- </a>
- <a
- href="https://google.com"
- rel="noopener noreferrer"
- target="_blank"
- >
- <gr-icon class="link" icon="help"> </gr-icon>
- <span> Link to help page </span>
- </a>
- <a
- href="https://google.com"
- rel="noopener noreferrer"
- target="_blank"
- >
- <gr-icon class="link" icon="history"> </gr-icon>
- <span> Link to result history </span>
- </a>
- </div>
- <div class="links">
- <a
- href="https://google.com"
- rel="noopener noreferrer"
- target="_blank"
- >
- <gr-icon class="link" icon="open_in_new"> </gr-icon>
- <span> Link to details </span>
- </a>
- <a
- href="https://google.com"
- rel="noopener noreferrer"
- target="_blank"
- >
- <gr-icon class="link" filled="" icon="image"> </gr-icon>
- <span> Link to image </span>
- </a>
- </div>
- <div>
- <gr-icon custom="" icon="ai" small=""> </gr-icon>
- <span class="ai-generated"> AI Generated </span>
- by FAKE Error Finder Finder Finder Finder Finder Finder Finder
+ <div class="header-content">
+ <div class="links">
+ <a
+ href="https://google.com"
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <gr-icon class="link" icon="download"> </gr-icon>
+ <span> Download </span>
+ </a>
+ <a
+ href="https://google.com"
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <gr-icon class="link" icon="system_update"> </gr-icon>
+ <span> Download </span>
+ </a>
+ <a
+ href="https://google.com"
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <gr-icon class="link" filled="" icon="image"> </gr-icon>
+ <span> Link to image </span>
+ </a>
+ <a
+ href="https://google.com"
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <gr-icon class="link" filled="" icon="image"> </gr-icon>
+ <span> Link to image </span>
+ </a>
+ <a
+ href="https://google.com"
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <gr-icon class="link" filled="" icon="bug_report"> </gr-icon>
+ <span> Link for reporting a problem </span>
+ </a>
+ <a
+ href="https://google.com"
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <gr-icon class="link" icon="help"> </gr-icon>
+ <span> Link to help page </span>
+ </a>
+ <a
+ href="https://google.com"
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <gr-icon class="link" icon="history"> </gr-icon>
+ <span> Link to result history </span>
+ </a>
+ </div>
+ <div class="links">
+ <a
+ href="https://google.com"
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <gr-icon class="link" icon="open_in_new"> </gr-icon>
+ <span> Link to details </span>
+ </a>
+ <a
+ href="https://google.com"
+ rel="noopener noreferrer"
+ target="_blank"
+ >
+ <gr-icon class="link" filled="" icon="image"> </gr-icon>
+ <span> Link to image </span>
+ </a>
+ </div>
+ <div>
+ <gr-icon custom="" icon="ai" small=""> </gr-icon>
+ <span class="ai-generated"> AI Generated </span>
+ by FAKE Error Finder Finder Finder Finder Finder Finder Finder
+ </div>
</div>
<gr-endpoint-decorator name="check-result-expanded">
<gr-endpoint-param name="run"> </gr-endpoint-param>
@@ -263,11 +265,13 @@
assert.shadowDom.equal(
element,
/* HTML */ `
- <div class="links"></div>
- <div>
- <gr-icon custom="" icon="ai" small=""> </gr-icon>
- <span class="ai-generated"> AI Generated </span>
- by FAKE Super Check
+ <div class="header-content">
+ <div class="links"></div>
+ <div>
+ <gr-icon custom="" icon="ai" small=""> </gr-icon>
+ <span class="ai-generated"> AI Generated </span>
+ by FAKE Super Check
+ </div>
</div>
<gr-endpoint-decorator name="check-result-expanded">
<gr-endpoint-param name="run"> </gr-endpoint-param>
diff --git a/polygerrit-ui/app/elements/checks/gr-diff-check-result.ts b/polygerrit-ui/app/elements/checks/gr-diff-check-result.ts
index bccbe48..de6a373 100644
--- a/polygerrit-ui/app/elements/checks/gr-diff-check-result.ts
+++ b/polygerrit-ui/app/elements/checks/gr-diff-check-result.ts
@@ -161,6 +161,7 @@
div.tags {
display: flex;
justify-content: flex-start;
+ align-items: center;
}
div.actions {
display: flex;
diff --git a/polygerrit-ui/screenshots/Chromium/baseline/gr-diff-check-result-collapsed-dark.png b/polygerrit-ui/screenshots/Chromium/baseline/gr-diff-check-result-collapsed-dark.png
index 51fd307..1a01ce2 100644
--- a/polygerrit-ui/screenshots/Chromium/baseline/gr-diff-check-result-collapsed-dark.png
+++ b/polygerrit-ui/screenshots/Chromium/baseline/gr-diff-check-result-collapsed-dark.png
Binary files differ
diff --git a/polygerrit-ui/screenshots/Chromium/baseline/gr-diff-check-result-collapsed.png b/polygerrit-ui/screenshots/Chromium/baseline/gr-diff-check-result-collapsed.png
index 518eac2..cd8f54b 100644
--- a/polygerrit-ui/screenshots/Chromium/baseline/gr-diff-check-result-collapsed.png
+++ b/polygerrit-ui/screenshots/Chromium/baseline/gr-diff-check-result-collapsed.png
Binary files differ
