| commit | ffc3775d2aa09cc14b9a2819f5117ed236f61c0a | [log] [tgz] |
|---|---|---|
| author | Antonio Barone <syntonyze@gmail.com> | Wed Sep 24 12:23:40 2025 +0200 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Wed Sep 24 07:26:56 2025 -0700 |
| tree | 047a69ab8190f2223495840809aaa9b064c84356 | |
| parent | dd952f9d1b7a76111611d7c3295558ab696b65a5 [diff] |
Skip unloadable changes in ChangesByProjectCache getUpdatedChangeDatas() caught exceptions while loading a change, but still returned the entry. Downstream permission/visibility checks during git-upload-pack then encountered the invalid change and triggered an Internal Server Error. This issue was visible on replicas, since they do not rely on the change index for visibility checks but instead load changes directly from NoteDb. As a result, corrupted or unloadable changes caused errors to bubble up to clients. This change skips any change that fails to load by continuing the loop from the catch block. The existing log at finest is preserved, and bad changes no longer leak into the result list. Effects: - Avoids failures during git-upload-pack when visibility is evaluated. - Ensures the cache returns only valid ChangeData. - Maintains resilience: one bad change does not block others. Bug: Issue 446941362 Release-Notes: Fixed git-upload-pack errors on replicas by skipping unloadable changes Change-Id: If20740fd861f2321f0b9d893bd6f0376042afa2c (cherry picked from commit 8a6d152f6929c2caa612fcc972de06b552ba063c)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.