commit ff41c0718d4c13483722017e6f4e895c2300e41b
author Edwin Kempin <ekempin@google.com> Wed Nov 30 10:38:39 2016 +0100
committer Edwin Kempin <ekempin@google.com> Wed Nov 30 11:37:00 2016 +0100
tree 70dad7d721df8d8a2d3f19583e841211b97c7393
parent 9875c00ed9366180ffcde6f221a17e1dc0e27bcb

Trim assignees

Be nice to users that overlook whitespace-only input.

Change-Id: I703f6b56f711a90b3ad065c0be16a9ba36ec607c
Signed-off-by: Edwin Kempin <ekempin@google.com>

gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Assignee.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Assignee.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Assignee.java
index f1489bb..7d6b1c3 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Assignee.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Assignee.java
@@ -113,6 +113,8 @@
     if (currentAssignee != null) {
       suggestBox.setText(FormatUtil.nameEmail(currentAssignee));
       suggestBox.selectAll();
+    } else {
+      suggestBox.setText("");
     }
   }
 
@@ -137,7 +139,7 @@
   }
 
   private void editAssignee(final String assignee) {
-    if (assignee.isEmpty()) {
+    if (assignee.trim().isEmpty()) {
       ChangeApi.deleteAssignee(changeId.get(),
           new GerritCallback<AccountInfo>() {
             @Override

gerrit-server/src/main/java/com/google/gerrit/server/change/PutAssignee.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/PutAssignee.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/PutAssignee.java
index 5002436..d377cad 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/change/PutAssignee.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/PutAssignee.java
@@ -14,7 +14,6 @@
 
 package com.google.gerrit.server.change;
 
-import com.google.common.base.Strings;
 import com.google.gerrit.common.TimeUtil;
 import com.google.gerrit.extensions.api.changes.AddReviewerInput;
 import com.google.gerrit.extensions.api.changes.AssigneeInput;
@@ -65,7 +64,7 @@
     if (!rsrc.getControl().canEditAssignee()) {
       throw new AuthException("Changing Assignee not permitted");
     }
-    if (Strings.isNullOrEmpty(input.assignee)) {
+    if (input.assignee == null || input.assignee.trim().isEmpty()) {
       throw new BadRequestException("missing assignee field");
     }