ff29dca4de07f63fdd3183d8833c79b1a6694892 - gerrit

commit	ff29dca4de07f63fdd3183d8833c79b1a6694892	[log] [tgz]
author	Shawn O. Pearce <sop@google.com>	Tue May 01 17:21:03 2012 -0700
committer	Shawn O. Pearce <sop@google.com>	Tue May 01 17:21:03 2012 -0700
tree	c48d6e512b43c3061fa4f9444b5c3df3ebb948cf
parent	f93b3eececa1393c06cc3abee70f66af6c82b1e5 [diff]

Pass PatchSet not PatchSet.Id to canSubmit()

All but one of the callers of canSubmit() already had the PatchSet
loaded in memory. Since canSubmit() generally needs the PatchSet
object, pass it through, avoiding a secondary database query.

Change-Id: I96fe842b3698deeb41612c61a78d54e9a6dbc4d6

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/ChangeDetailFactory.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/PatchSetPublishDetailFactory.java[diff]
gerrit-server/src/main/java/com/google/gerrit/rules/StoredValues.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/changedetail/Submit.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/patch/PatchSetInfoFactory.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/project/ChangeControl.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/query/change/ListChanges.java[diff]
gerrit-server/src/main/java/gerrit/PRED__load_commit_labels_1.java[diff]

8 files changed