| commit | fefce2217ca93efe4cd0c59650e523ab2723da5d | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Mon Feb 06 15:12:16 2017 -0500 |
| committer | Edwin Kempin <ekempin@google.com> | Tue Feb 07 10:53:43 2017 +0100 |
| tree | f50ee0ba795e463a8f53827c634fa04aa14e2961 | |
| parent | a460855224a3436e57b3a1b02484779a83027f4c [diff] |
ChangeRebuilder: Fix grouping of events containing tags When considering whether a given event can be grouped together with previous events, one consideration is the tag field. However, not every event type can have a tag; for example, there are no tags associated with reviewer status updates. This means that we can't just inspect the *last* change in the current list to compare tags, we have to inspect all events. Similarly, we can merge an event having a tag with a previous list if none of the previous list can even accept tags. This fixes the biggest outstanding issue with GERRIT_NOTEDB=CHECK, which complained about incorrect postSubmit bits on the SUBM approval. In order to correctly set postSubmit = false on SUBM, it must be grouped in the same NoteDb update as the StatusChangeEvent. But going by the natural sort, the ApprovalEvent was *after* the StatusChangeEvent, and this tag issue was preventing them from being merged. This change fixes a general issue with event sorting and grouping that was manifesting as a problem with the SUBM approval, but it's not actually a guaranteed fix for the SUBM grouping issue. A direct hard-coded fix may be implemented later, depending on how well this fix lines up with real-world data. Change-Id: I78239480680889a143b9c41368461430b0cda21b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.