commit fef096c00dcf3f6263801f63dd9d760b79cd2f03
author Shawn O. Pearce <sop@google.com> Mon Feb 16 09:52:28 2009 -0800
committer Shawn O. Pearce <sop@google.com> Mon Feb 16 10:22:10 2009 -0800
tree 2f2cde21a40c06e0ee52e12c4ef31cffe24827b3
parent 24d344a10c258a16526dcf007f3a2e0c3fe1361a

Fix detach assertion error caused by loading messing being removed

Apparently when we delete a RootPanel's DOM element from the host
page we also must call detachNow() to remove it from the cleanup
list within GWT, otherwise the onUnload handler for the page has
an assertion error in hosted mode.

Signed-off-by: Shawn O. Pearce <sop@google.com>

src/main/java/com/google/gerrit/client/Gerrit.java

diff --git a/src/main/java/com/google/gerrit/client/Gerrit.java b/src/main/java/com/google/gerrit/client/Gerrit.java
index db8b8fd..5e709d9 100644
--- a/src/main/java/com/google/gerrit/client/Gerrit.java
+++ b/src/main/java/com/google/gerrit/client/Gerrit.java
@@ -280,6 +280,7 @@
   private void showInitialScreen() {
     final RootPanel sg = RootPanel.get("gerrit_startinggerrit");
     sg.getElement().getParentElement().removeChild(sg.getElement());
+    RootPanel.detachNow(sg);
 
     History.addHistoryListener(new Link());
     if ("".equals(History.getToken())) {