| commit | fe04fe7f58f1f8face2627eba380bc96bbcb87f8 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Fri Aug 01 16:03:38 2014 -0700 |
| committer | Dave Borowitz <dborowitz@google.com> | Mon Aug 04 12:20:34 2014 -0700 |
| tree | 647061db1a8ab8f17a49f72e370bcd4f07127dd1 | |
| parent | b5db58b4d93b6eb378ec48d1cec6c93fee2b6d44 [diff] |
Don't leak IOException error messages from CommitValidators These may leak low-level implementation details that are useless to end users. Log instead. Change-Id: I86e81d2b9f0c3dcef7f88f234bb8eef83e582595
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java b/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java index 0c0065c..cad5174 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/git/validators/CommitValidators.java
@@ -538,7 +538,9 @@ } return Collections.emptyList(); } catch (IOException e) { - throw new CommitValidationException(e.getMessage(), e); + String m = "error checking banned commits"; + log.warn(m, e); + throw new CommitValidationException(m, e); } } }