| commit | fdd70abc9eda2041fc04d1093a9da69432c5f4d6 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Apr 21 13:24:10 2022 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Thu Apr 21 13:27:58 2022 +0200 |
| tree | 680a959ecd69e293c5ea16d7739caa50dcd7d820 | |
| parent | efde2454634b6e9e4ea94432853644783f385c03 [diff] |
ApprovalsUtil#persistCopiedApprovals: Only store copied approvals as copied ApprovalCopier#forPatchSet returns all approvals of the patch set, approvals that have been copied from the previous patch set but also approvals which have been applied on the patch set. The copied approvals can be distinguished from the other approvals by the copied flag that is set to true for them. When persisting approvals as copied we should only store the approvals that have been copied (copied flag is set) but not other approvals that have been applied on the patch set. Hence we filter for approvals with the copied flag in ApprovalsUtil#persistCopiedApprovals now. In practice storing all approvals as copied approvals may not have been a problem, since ApprovalsUtil#persistCopiedApprovals is only called on newly created patch sets that do not have any approvals yet, so the only approvals that are returned by ApprovalCopier#forPatchSet are copied approvals. However having the filter in place makes the method less error-prone and also improves the readability (readers no loner need to wonder why non-copied approvals are potentially stored as copied approvals). Signed-off-by: Edwin Kempin <ekempin@google.com> Release-Notes: skip Change-Id: Ia5326f1c7b0ceb9b135e8d80a996c7e3afa441f2
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.