| commit | fda0e4244c5fd5af101c2db9a1c1bd2f41b1384d | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Fri Feb 11 14:39:02 2022 +0100 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Mon Feb 14 17:12:56 2022 +0100 |
| tree | 8f3d7fd72fe1f5680ee0680c7decc286629707ec | |
| parent | 22da6ddbce5870b683f0925626409ec9e9351f5b [diff] |
Allow querying submit requirements using the label operator
This change is preserving backward compatibility of the label operator
using the status operand with new submit requirements. Previously users
were able to query labels like:
* label:Code-Review=NEED
* or, label:Code-Review=OK
These queries were matching with changes that emitted a submit record
with status=NEED or status=OK respectively. Submit records were emitted
when there were label functions, or custom/prolog submit rules
configured for the project, but these are being deprecated.
With the new submit requirements, submit records are no longer emitted.
This means that any queries with the label formats mentioned above will
no longer match with changes.
In this change, we backfill entries for the label operator with the
status operand from submit requirement results using the following
rules:
* if SR result = UNSATISFIED, we emit two label entries: NEED, REJECT
* if SR result = SATISFIED or OVERRIDDEN, we emit two label entries:
OK, MAY.
For example if a change has a "CR" requirement that is satisfied, a
query with "label:CR=OK" or "label:CR=MAY" will match with the change.
With this change, the format
<label-name>=<submit-record-status>,<approver>
will not work with backfilled submit requirement results. We might
consider implementing this in a future change if there is a need for it.
The implementation is using the submit requirement name as if it was a
label name. This is not very accurate since a SR might rely on some
conditions that's not using labels, but we accept this to simplify the
implementation.
Note that this change also marks the operator
`label:<label-name>=<status>` as deprecated since users should not rely
on it anymore. We'll implement a submit requirment predicate that
should be used for this use case instead.
Google-Bug-Id: b/218663294
Change-Id: Ic8b48101ba95a83a1b8a41bec3e976f1aa97c1e7
Release-Notes: Add support for querying SR Results using the label operator.
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.