| commit | fd4ad7e60d78bfa027d07f06fc520cabd3274fb2 | [log] [tgz] |
|---|---|---|
| author | Luke Granger-Brown <lukegb@google.com> | Sat Jul 25 23:54:18 2020 +0000 |
| committer | Luke Granger-Brown <lukegb@google.com> | Sat Jul 25 23:58:28 2020 +0000 |
| tree | 5425af0eeb26278ed8505cd0c80c28982a054314 | |
| parent | 072e762a385c4ebd2094f0f8e96c7db2ca6924b9 [diff] |
Fix gr-hovercard-behavior under Firefox Firefox doesn't implement toElement/fromElement (they're not in the spec, and were implemented by Chrome apparently for compatibility with IE), but does implement target and relatedTarget, which are part of the UI Events spec (https://w3c.github.io/uievents/#interface-mouseevent). Bug: Issue 13175 Change-Id: I9eeb26c032a38de9d7185749373c7982c796acb2
diff --git a/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.js b/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.js index 04c3166..3d5937b 100644 --- a/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.js +++ b/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.js
@@ -209,8 +209,8 @@ // from the hovercard but now hovering over the target (to stop an annoying // flicker effect), just return. if (opt_e) { - if (opt_e.toElement === this || - (opt_e.fromElement === this && opt_e.toElement === this._target)) { + if (opt_e.relatedTarget === this || + (opt_e.target === this && opt_e.relatedTarget === this._target)) { return; } }