Gerrit#updateUiLink: Fix access to undefined property
uiSwitcherLink attribute is instantiated conditionally, when PG UI was
not disabled. The invocation of setHref() method on it:
uiSwitcherLink.setHref(getUiSwitcherUrl(token));
was done unconditionally. That leads to this error:
(TypeError) : Cannot read property 'setHref' of undefined
Bug: Issue 5929
Change-Id: I872cdf7d41ab36e03126df54bb12c9071da5543d
diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java
index 17ad4f6..751302e 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/Gerrit.java
@@ -598,7 +598,9 @@
}
private static void updateUiLink(String token) {
- uiSwitcherLink.setHref(getUiSwitcherUrl(token));
+ if (uiSwitcherLink != null) {
+ uiSwitcherLink.setHref(getUiSwitcherUrl(token));
+ }
}
private void onModuleLoad2(HostPageData hpd) {
