| commit | fc2ddc967875a75f13df041b35bac41e4e690a78 | [log] [tgz] |
|---|---|---|
| author | Luca Milanesio <luca.milanesio@gmail.com> | Tue Dec 10 07:37:17 2019 +0000 |
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Tue Dec 10 07:37:17 2019 +0000 |
| tree | 416e4a04ba63bf7dcf8d3517a1d356dcedeab5f5 | |
| parent | 7aba094fa3500bfb74fcb25cf319ffc29ffa1b7b [diff] | |
| parent | 1a11b40373b1576b3360ff7d2d7f25319ba89630 [diff] |
Merge "Update replication submodule for fixing test flakiness" into stable-3.1
* submodules:
* Update plugins/replication from branch 'stable-3.1'
to 0d91ffd189297f511c93d40a864978b5774805c1
- Synchronize access to ReplicationTasksStorage
The ReplicationTasksStorage can be subject to concurrency issues when a
replication task is moved across directories (waiting/running/building)
concurrently with the listing.
The result of the uncontrolled concurrency could be lead to:
1. Flaky tests because of the replication tasks found two or more times
in different directories
2. Flaky tests because of the failure to list replication tasks
that are escaping across directories because of the rename
3. File-based exceptions when replication tasks are moved concurrently
by two threads to different directories.
The replication tasks storage is supposed to contain only small files and only
in-flight operations: the overhead of the additional synchronisation is thus
negligible compared to the overall latency of the replication itself.
To eliminate all residual latency, cleanup all the replication tasks
on all subdirectories at the start of the tests.
Bug: Issue 11843
Change-Id: I5f6293b3f22f0943df79f8ab2cb2c217210e5236
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.