| commit | fb64381f7c7c1ad610dc58aa450cfc1f74b6576f | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Sun Jan 13 10:57:45 2019 +0100 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Wed Apr 24 07:49:35 2019 +0000 |
| tree | 7ae84bbe036837c83e7bd402572f46a54318cba8 | |
| parent | 40d2be69dbfbb236554e56000c14f99335b0b3c8 [diff] |
Revert "Revert "Allow to enable git protocol version 2 for upload pack"" Reason for revert: The original revert was done because of security vulnerability in JGit. This vulnerability was fixed meantime. Another argument for procrastination with Git v2 protocol support in upcoming Gerrit release may be the fact that we do not have any integration tests for execution of AdvertiseRefsHook hook. However, this argument is not specific for git v2 protocol, as mentioned in JGit 5.0 release: [1], but other Git protocol versions were affected as well, and thus does not hold. In fact bidirectional v0 HTTP protocol also has not executed AdvertiseRefsHook hook and this was not discovered for 8 years and all released Gerrit versions were affected. Test Plan: 1. Install git version 2.18 or later 2. Activate git v2 protocol on the client side 3. Enable git v2 protocol support in gerrit, by setting this config: receive.enableProtocolV2 = true 3. Run $ GIT_TRACE_PACKET=1 git ls-remote 4. Confirm that git v2 protocol is used 5. Confirm that the method: DefaultRefFilter#filter is get called 6. Confirm that the call stack looks sane: [2] This reverts commit f51a97d523fd3022c1c8892c2481047c65cdc160. [1] https://projects.eclipse.org/projects/technology.jgit/releases/5.0.0 [2] http://paste.openstack.org/show/742267 Change-Id: I5e2e5c7c69cc1433bc8539a8c36cb2ebd70804fc
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.