commit fb19356c106c037c331804a47020c4affdbda1a2
author David Ostrovsky <david@ostrovsky.org> Mon May 19 22:48:33 2014 +0200
committer David Ostrovsky <david.ostrovsky@gmail.com> Tue May 20 06:08:32 2014 +0000
tree 3fd6d46ad483086dddc5934ca34578e65cd72638
parent 2806f76434368e5581341bf2537067de099f7530

Buck: Fix compilation of GWT plugins

I1f13f4d29 broke compilation of GWT plugins. Also remove unnecessary
dependency of GWT development library.

Change-Id: Ic3ada6a56ddd3b83bfa51d504e525aa52021b6ad

gerrit-gwtui/BUCK

diff --git a/gerrit-gwtui/BUCK b/gerrit-gwtui/BUCK
index 6525ed6..8dc277a 100644
--- a/gerrit-gwtui/BUCK
+++ b/gerrit-gwtui/BUCK
@@ -29,7 +29,7 @@
   name = 'ui_opt',
   modules = [MODULE],
   module_deps = [':ui_module'],
-  deps = DEPS + ['//lib/gwt:dev', ':ui_dbg'],
+  deps = DEPS + [':ui_dbg'],
   local_workers = cpu_count(),
   strict = True,
   experimental_args = GWT_COMPILER_ARGS,
@@ -42,7 +42,7 @@
   style = 'PRETTY',
   optimize = 0,
   module_deps = [':ui_module'],
-  deps = DEPS + ['//lib/gwt:dev'],
+  deps = DEPS,
   local_workers = cpu_count(),
   strict = True,
   experimental_args = GWT_COMPILER_ARGS,

tools/default.defs

diff --git a/tools/default.defs b/tools/default.defs
index a8a323f..4c6e898 100644
--- a/tools/default.defs
+++ b/tools/default.defs
@@ -126,12 +126,14 @@
     gwt_binary(
       name = name + '__gwt_application',
       modules = [gwt_module],
-      deps = [':%s__plugin' % name] + gwt_deps,
+      deps = gwt_deps,
+      module_deps = [':%s__plugin' % name],
       local_workers = cpu_count(),
       strict = True,
       experimental_args = GWT_COMPILER_ARGS,
       vm_args = GWT_JVM_ARGS,
     )
+
   java_binary(
     name = name,
     manifest_file = genfile('MANIFEST.MF'),