commit | e22bfc3afa60ca691d6a91ec34010f01c802bfea | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Tue Mar 10 14:07:10 2020 +0100 |
committer | Thomas Draebing <thomas.draebing@sap.com> | Thu Jun 04 18:34:51 2020 +0200 |
tree | 2f9a82fa5514dc91eec468896680db415b4048df | |
parent | 022280fcaa38d76f23eee430d292f90505b6af79 [diff] |
Support /COMMIT_MSG for change edit REST endpoints The change edit REST endpoints to get and set file contents failed with "409 Conflict: Invalid path: /COMMIT_MSG" if the magic file "/COMMIT_MSG" is used to update the commit message. This is what is currently used by PolyGerrit if you have a change edit, open the diff via for the commit message and then try to edit and save the file content. Updating the commit message of change edits from the change screen works, because that is using a dedicated REST endpoint to update the commit message. This fix makes the change edit REST endpoints aware of the magic file "/COMMIT_MSG" by making them forward the request to the dedicated REST endpoints to get/set the commit message. Alternatively PolyGerrit could be changed to directly use these REST endpoints when the commit message is edited. Bug: Issue 11706 Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I5c2ef8dbabe72e04ed61606e7b923d877efa3a23
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.