commit fa24285157e439a7d93d51baccaa0c02090db439
author Ole Rehmsen <oler@google.com> Fri Jan 29 11:02:25 2021 +0100
committer Ole Rehmsen <oler@google.com> Wed Feb 03 09:02:50 2021 +0100
tree 00097e973a9b3fa1fb6ec529c103ea7757fa7076
parent ea897cd754d86b38300d70a177ef91d3c5e34571

Move comment patchset logic to gr-diff-host

This is a step towards making gr-diff oblivious of the specifics of the
selected PatchRange. This makes it easier to reuse gr-diff independently
of the underlying versioning system.

A comment's patchset (and commentSide, already in gr-diff-host) together
determine which patch set a comment is stored on. This is usually the
patchset the user left the comment on, except in the case of PARENT and
merge parent versions which are not patchsets and cannot store comments.

Change-Id: I5e7e30f93ee5a74fe8f2c2e6b225282246c51bd9

polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js
index ad46bcd..0c1a92d 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js
+++ b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js
@@ -966,7 +966,6 @@
 
       element.dispatchEvent(new CustomEvent('create-comment', {
         detail: {
-          patchNum: 2,
           lineNum: 3,
           side: diffSide,
           path: '/p',
@@ -989,10 +988,13 @@
         end_line: 1,
         end_character: 3,
       };
+      element.patchRange = {
+        basePatchNum: 'PARENT',
+        patchNum: 3,
+      };
 
       element.dispatchEvent(new CustomEvent('create-comment', {
         detail: {
-          patchNum: 3,
           lineNum: 1,
           side: diffSide,
           path: '/p',
@@ -1018,7 +1020,6 @@
 
       element.dispatchEvent(new CustomEvent('create-comment', {
         detail: {
-          patchNum: 2,
           side: Side.RIGHT,
         },
       }));
@@ -1037,7 +1038,6 @@
 
       element.dispatchEvent(new CustomEvent('create-comment', {
         detail: {
-          patchNum: 3,
           side: Side.LEFT,
         },
       }));
@@ -1056,7 +1056,6 @@
 
       element.dispatchEvent(new CustomEvent('create-comment', {
         detail: {
-          patchNum: 3,
           side: Side.LEFT,
         },
       }));
@@ -1075,7 +1074,6 @@
 
       element.dispatchEvent(new CustomEvent('create-comment', {
         detail: {
-          patchNum: 3,
           side: Side.LEFT,
         },
       }));
@@ -1097,8 +1095,6 @@
 
       element.dispatchEvent(new CustomEvent('create-comment', {
         detail: {
-          patchNum: 2,
-          lineNum: 3,
           side: diffSide,
           path: '/p',
         },
@@ -1123,8 +1119,6 @@
 
       element.dispatchEvent(new CustomEvent('create-comment', {
         detail: {
-          patchNum: 2,
-          lineNum: 3,
           side: diffSide,
           path: '/p',
         },
@@ -1149,11 +1143,8 @@
 
       element.dispatchEvent(new CustomEvent('create-comment', {
         detail: {
-          patchNum: 2,
-          lineNum: 3,
           side: diffSide,
           path: '/p',
-          range: undefined,
         },
       }));