Ensure change is WIP before firing WIP reviewer toast
Change 353134 incorrectly assumed startReview is true for active
changes, which means the toast was firing for active changes.
Check change is WIP before firing the toast.
Release-Notes: skip
Change-Id: I220177bf446da7ab82d89ee53e83940879c597f5
diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts
index 933d06f..767c4cf 100644
--- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts
+++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts
@@ -1407,7 +1407,7 @@
if (startReview) {
reviewInput.ready = true;
- } else {
+ } else if (this.change?.work_in_progress) {
const addedAccounts = [
...(this.reviewersList?.additions() ?? []),
...(this.ccsList?.additions() ?? []),
diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.ts b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.ts
index 52ea252..acb7c83 100644
--- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.ts
+++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.ts
@@ -1457,6 +1457,70 @@
}
}
+ suite('reviewer toast for WIP changes', () => {
+ let fireStub: sinon.SinonStub;
+ setup(() => {
+ fireStub = sinon.stub(element, 'dispatchEvent');
+ });
+
+ test('toast not fired if change is already active', async () => {
+ element.change = {
+ ...createChange(),
+ status: ChangeStatus.NEW,
+ };
+ element.send(false, false);
+
+ await waitUntil(() => fireStub.called);
+
+ const events = fireStub.args.map(arg => arg[0].type || '');
+ assert.isFalse(events.includes('show-alert'));
+ });
+
+ test('toast is not fired if change is WIP and becomes active', async () => {
+ const account = createAccountWithId(22);
+ element.reviewersList!.accounts = [];
+ element.reviewersList!.addAccountItem({account, count: 1});
+ element.reviewersList!.dispatchEvent(
+ new CustomEvent('account-added', {
+ detail: {account},
+ })
+ );
+ element.change = {
+ ...createChange(),
+ status: ChangeStatus.NEW,
+ work_in_progress: true,
+ };
+ element.send(false, true);
+
+ await waitUntil(() => fireStub.called);
+
+ const events = fireStub.args.map(arg => arg[0].type || '');
+ assert.isFalse(events.includes('show-alert'));
+ });
+
+ test('toast is fired if change is WIP and becomes active and reviewer added', async () => {
+ const account = createAccountWithId(22);
+ element.reviewersList!.accounts = [];
+ element.reviewersList!.addAccountItem({account, count: 1});
+ element.reviewersList!.dispatchEvent(
+ new CustomEvent('account-added', {
+ detail: {account},
+ })
+ );
+ element.change = {
+ ...createChange(),
+ status: ChangeStatus.NEW,
+ work_in_progress: true,
+ };
+ element.send(false, false);
+
+ await waitUntil(() => fireStub.called);
+
+ const events = fireStub.args.map(arg => arg[0].type || '');
+ assert.isTrue(events.includes('show-alert'));
+ });
+ });
+
test('cc confirmation', async () => {
testConfirmationDialog(true);
});
