commit 4d3281729a653cf071027abec27fe39714a1dfe2
author Kamil Musin <kamilm@google.com> Mon Feb 26 13:11:14 2024 +0100
committer Kamil Musin <kamilm@google.com> Wed Feb 28 13:35:57 2024 +0100
tree a668ea845a7413e9e22d0008fa709b1fe82e560a
parent 04bf9daccd8efe34c32790f1454f790f072f9fdf

Change executeChangeActions to parse the response

The corresponding actions are most often used in gr-change-actions which
is then manually calling readJSONResponsePayload. This is confusing and
adds unnecessary complexity at the callsite. The confusion is
exemplified by the subtle bugs present in the code (explained below).

In gr-change-actions:
`response is guaranteed to be ok (due to semantics of rest-api methods)`
- this comment was present in the handleResponse previously and isn't
correct. The rest-api method that does error handling was (before the
refactor)
https://gerrit.googlesource.com/gerrit/+/66c3684c0183a98ea61e0b7a312f0d5d331cb4a9/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper.ts#498
As can be seen from the implementation, the method only returns
undefined if the fetch itself fails. If non-ok status is returned then
the response itself is returned. With the change to fetchJSON this is
now correct.

In gr-confirm-cherrypick-dialog and gr-editor-view, the code incorrectly
assumed that on error promise rejects (`.then` is not called). This is
incorrect in both previous and current version of the code. If the
server returns non-ok response promise resolves. Added explicit checking
for the `undefined`, which is now returned on non-ok status.

gr-change-list-bulk-abandon-flow.ts uses
BulkActionsModel.abandonChanges, but it passes a errFn that throws on
error and therefore doesn't have the same issue with non-ok status.

Also removed stubbing of rest-api `send` in the test, as the method is
never called in the tests (before this change as well).

NB: executeChangeActions doesn't affect the extra actions defined by the
plugins, those are handled separately by the plugin logic.

Google-Bug-Id: b/297849592
Release-Notes: skip
Change-Id: I0c0a97f3ae32e8d099a0ef19d4ba7486fe1867c0